-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Added tutorials for Holistic Trace Analysis #2723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2723
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 65d7154 with merge base 0fe2a10 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
requirements.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a temp change not meant to land
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, fixing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not sure if beginner
folder is the right one for it, as other profiling tutorials are in the intermediate, aren't they?
There are two tutorials tagged with profiling. One of them is in beginner and the other one is in intermediate. These are introductory HTA tutorials so I placed them in the beginners folder. |
Fixes 2724
Description
beginner/profiler
and the two HTA tutorials. The left panel entry will allow users to find tutorials related to profiling easily. See attached image.Checklist