Skip to content

Added tutorials for Holistic Trace Analysis #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Conversation

anupambhatnagar
Copy link
Contributor

@anupambhatnagar anupambhatnagar commented Dec 28, 2023

Fixes 2724

Description

  • Added two tutorials for HTA
    • Introduction to HTA
    • TraceDiff using HTA
  • Created a left panel entry called "Profiling PyTorch" which now contains the introductory beginner/profiler and the two HTA tutorials. The left panel entry will allow users to find tutorials related to profiling easily. See attached image.

Screenshot 2023-12-28 at 2 01 00 PM

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

Copy link

pytorch-bot bot commented Dec 28, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2723

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 65d7154 with merge base 0fe2a10 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@anupambhatnagar anupambhatnagar added the Profiler Issues relating to profiler tutorials label Dec 28, 2023
requirements.txt Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a temp change not meant to land

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, fixing it.

@aaronenyeshi aaronenyeshi requested a review from svekars December 28, 2023 22:19
Copy link
Member

@aaronenyeshi aaronenyeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great!

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure if beginner folder is the right one for it, as other profiling tutorials are in the intermediate, aren't they?

@anupambhatnagar
Copy link
Contributor Author

LGTM, not sure if beginner folder is the right one for it, as other profiling tutorials are in the intermediate, aren't they?

There are two tutorials tagged with profiling. One of them is in beginner and the other one is in intermediate. These are introductory HTA tutorials so I placed them in the beginners folder.

@anupambhatnagar anupambhatnagar merged commit 765d428 into main Jan 2, 2024
@svekars svekars added the 2.2 label Jan 10, 2024
@svekars svekars removed the 2.2 label Jan 26, 2024
@svekars svekars deleted the hta-tutorials branch January 26, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Profiler Issues relating to profiler tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 Request - Tutorials for Holistic Trace Analysis
5 participants