Skip to content

[ao] adding note about warning to static quant tutorial #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 16, 2023

Conversation

HDCharles
Copy link
Contributor

Fixes pytorch/pytorch#40278

Description

added a note to the tutorial that users may see a warning about calibration, related to pytorch/pytorch#40278

Checklist

  • [ x] The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • [ x] Only one issue is addressed in this pull request
  • [ x] Labels from the issue that this PR is fixing are added to this pull request
  • [ x] No unnecessary issues are included into this pull request.

Summary: users reported seeing a warning when running a tutorial, add a
comment calling this out as expected.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
Summary: users reported seeing a warning when running a tutorial, add a
comment calling this out as expected.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@HDCharles HDCharles added the quantization Issues relating to quantization tutorials label Dec 8, 2023
Copy link

pytorch-bot bot commented Dec 8, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2705

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit de3fb5b with merge base a92ddf4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@HDCharles HDCharles changed the title Gh/hd charles/2/base [ao] adding note about warning to static quant tutorial Dec 8, 2023
HDCharles and others added 3 commits December 11, 2023 18:02
fix spelling grammar

Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
@HDCharles
Copy link
Contributor Author

@svekars are these spelling failures necessary to fix, they're unrelated to hte PR?

@svekars
Copy link
Contributor

svekars commented Dec 14, 2023

are these spelling failures necessary to fix, they're unrelated to hte PR?

not related and should be fixed now - I relaunched the build - it should resolve.

@svekars svekars merged commit 79474b1 into main Dec 16, 2023
@facebook-github-bot facebook-github-bot deleted the gh/HDCharles/2/base branch January 8, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed quantization Issues relating to quantization tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Observer in Quantization throws Warning
4 participants