Skip to content

Added optimizer compile recipe #2700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jan 24, 2024
Merged

Added optimizer compile recipe #2700

merged 19 commits into from
Jan 24, 2024

Conversation

mlazos
Copy link
Contributor

@mlazos mlazos commented Dec 8, 2023

Add optimizer compile recipe

cc @williamwen42 @msaroufim

Copy link

pytorch-bot bot commented Dec 8, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2700

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5d71ad6 with merge base 219a9e3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@williamwen42 williamwen42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM generally, ensure preview is as expected.

Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple editorial nits.

@svekars svekars added 2.2 torch.compile Torch compile and other relevant tutorials labels Dec 8, 2023
mlazos and others added 2 commits December 8, 2023 10:43
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
Co-authored-by: William Wen <williamwen@meta.com>
@mlazos mlazos changed the title Added optimizer compile tutorial Added optimizer compile recipe Dec 8, 2023
@mlazos mlazos requested a review from svekars December 8, 2023 18:57
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will merge the week of Jan 2.

@svekars svekars merged commit 1ace4ee into main Jan 24, 2024
@svekars svekars deleted the mlazos/compile-opt branch January 24, 2024 17:43
HDCharles pushed a commit that referenced this pull request Jan 26, 2024
* Added optimizer compile tutorial
---------

Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
Co-authored-by: William Wen <williamwen@meta.com>
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
svekars added a commit that referenced this pull request Feb 2, 2024
* Added optimizer compile tutorial
---------

Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
Co-authored-by: William Wen <williamwen@meta.com>
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.2 cla signed torch.compile Torch compile and other relevant tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants