Skip to content

Small typo in DQN tutorial #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Small typo in DQN tutorial #2694

merged 1 commit into from
Dec 4, 2023

Conversation

L0Z1K
Copy link
Contributor

@L0Z1K L0Z1K commented Nov 29, 2023

Description

I realized that the link for Gymnasium cannot be accessed because of typo.
Now, you can access the gymnasium website by hyperlink!

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @svekars @carljparker

Copy link

pytorch-bot bot commented Nov 29, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2694

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit aca4b87 with merge base 5c632a0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @L0Z1K!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@svekars
Copy link
Contributor

svekars commented Nov 29, 2023

Thanks! Can you please sign the CLA?

@L0Z1K
Copy link
Contributor Author

L0Z1K commented Nov 30, 2023

@svekars Did it! :)

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@svekars svekars merged commit 37462ab into pytorch:main Dec 4, 2023
@L0Z1K L0Z1K deleted the patch-1 branch December 6, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants