corrected the example for cross-correlation with scipy #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is fully correct with appropriate gradients
…lation with scipy - the example is fully correct with appropriate gradients
…torials into correct-scipy-extension
soumith
approved these changes
Jul 1, 2018
|
thanks @adam-dziedzic ! |
|
You're welcome @soumith ! |
10 tasks
rodrigo-techera
pushed a commit
to Experience-Monks/tutorials
that referenced
this pull request
Nov 29, 2021
* corrected the example with cross-correlation with scipy - the example is fully correct with appropriate gradients * improve the code and comments; corrected the example with cross-correlation with scipy - the example is fully correct with appropriate gradients * keep the include in the previous place * remove spurious new lines * small changes * flipped filter or cross-correlation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully correct gradients for the scipy example (checked with torch.autograd.gradcheck).