[BE] Move data download logic to download_data.py
#2581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `download_url_to_file` which is heavily inspired by https://github.com/pytorch/pytorch/blob/efb73fe8e4413a0d6db078e85c7ed7c91f05ca5d/torch/hub.py#L600 Skip slow/flaky downloads if `FILES_TO_RUN` is defined, but tutorial is not in this shard Add dcgan_tutorial (which has a massive 1Gb downloadable) and fgsm_tutorial to list of tutorials with optinal downloadable data
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2581
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7d0c473 with merge base 309c889 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
download_url_to_filewhich is heavily inspired by torch/hub.pysize_fmtis borrowed from torch/autograd/profiler_util.pyFILES_TO_RUNis defined, but tutorial is not in this shard, i.e.:download_dcgan_data(which is 1Gb+ downloadable) only fordcgan_tutorialdownload_lenet_mnist(downloads from rate-limited GDrive) only forfgsm_tutorialdownload_hymenoptera_dataonly fortransfer_learning_tutorialdownload_nlp_dataforseq2seq_translation_tutorial,char_rnn_classification_tutorialandchar_rnn_generation_tutorial