Skip to content

Fuse optimizer into backward tutorial #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 2, 2023
Merged

Fuse optimizer into backward tutorial #2568

merged 9 commits into from
Oct 2, 2023

Conversation

janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Sep 23, 2023

Description

Add tutorial introducing the memory saving technique of fusing optim into bwd.
I still have to add this to a toc file somewhere, but I am not quite sure this is a recipe vs tutorial. How bite-sized is this?

https://docs-preview.pytorch.org/pytorch/tutorials/2568/intermediate/optimizer_step_in_backward_tutorial.html?highlight=fusing%20optimizer#id1

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 23, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2568

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ae024eb with merge base b69a12a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@janeyx99 janeyx99 changed the title Optim bwd tutorial Fuse optimizer into backward tutorial Sep 23, 2023
@janeyx99 janeyx99 requested review from svekars and albanD September 23, 2023 05:22
@janeyx99 janeyx99 marked this pull request as ready for review September 23, 2023 05:22
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few editorial suggestions.

@svekars svekars mentioned this pull request Sep 25, 2023
4 tasks
@svekars svekars added the 2.1 label Sep 26, 2023
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more to help pass the pyspelling check.

Copy link
Contributor

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits but LGTM!

Copy link
Contributor

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Base automatically changed from 2.1-RC-TEST to main October 2, 2023 19:54
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@svekars svekars merged commit 202ba9a into main Oct 2, 2023
@svekars svekars deleted the optim-bwd-tutorial branch October 2, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants