-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Fuse optimizer into backward tutorial #2568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2568
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ae024eb with merge base b69a12a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few editorial suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple more to help pass the pyspelling check.
a4c48cc
to
4ba0518
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits but LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Fixing formatting
Description
Add tutorial introducing the memory saving technique of fusing optim into bwd.
I still have to add this to a toc file somewhere, but I am not quite sure this is a recipe vs tutorial. How bite-sized is this?
https://docs-preview.pytorch.org/pytorch/tutorials/2568/intermediate/optimizer_step_in_backward_tutorial.html?highlight=fusing%20optimizer#id1
Checklist