Skip to content

Temporary manual update for tv tutorial ipynb #2545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

vfdev-5
Copy link
Contributor

@vfdev-5 vfdev-5 commented Sep 4, 2023

Description:

TL;DR: We need torchvision nightly to run correctly python tutorial from #2540 and according to @NicolasHug, we can't install torchvision nightly to the CI. He suggested to update the colab notebook (this PR)

Here we send a PR to gh-pages branch directly same as previously torchvision tutorial notebook was pushed

After v0.16 release we can remove this notebook once #2540 is merged

Result:

@vfdev-5 vfdev-5 requested a review from NicolasHug September 4, 2023 14:30
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 4, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2545

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Merge Blocking SEVs

There is 1 active merge blocking SEVs. Please view them below:

If you must merge, use @pytorchbot merge -f.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vfdev-5 vfdev-5 changed the title Temporary manual update for tv tutorial Temporary manual update for tv tutorial ipynb Sep 6, 2023
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @vfdev-5 . Can you please update this notebook with the same changes made in #2546 so we can merge it? Thanks!

@vfdev-5
Copy link
Contributor Author

vfdev-5 commented Sep 6, 2023

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vfdev-5

@vfdev-5 vfdev-5 merged commit 9d39ff2 into gh-pages Sep 6, 2023
@vfdev-5 vfdev-5 deleted the update-tv-tut-ipynb-gh-pages branch September 6, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants