[ONNX 2] Add ONNX tutorial using torch.onnx.dynamo_export API #2541

thiagocrepaldi · 2023-09-01T21:40:38Z

This PR adds a tutorial that demonstrates how to use torch.onnx.dynamo_export to export a PyTorch model to ONNX using the latest TorchDynamo backend

It also refactors an existing ONNX Exporter tutorial to let users know that it uses the now to-be-deprecated ONNX exporter API

cc @BowenBao @williamwen42 @msaroufim

FIXES: #2543

pytorch-bot · 2023-09-01T21:40:40Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2541

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 8facb1e with merge base 677c1b6 ():

NEW FAILURE - The following job has failed:

Build tutorials / pytorch_tutorial_build_manager (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

msaroufim

a few comments, @svekars please merge if they get addressed

beginner_source/export_simple_model_to_onnx_tutorial.py

abock

Looking good, but some wording suggestions to not imply deprecation/legacy/default.

advanced_source/super_resolution_with_onnxruntime.py

beginner_source/export_simple_model_to_onnx_tutorial.py

thiagocrepaldi · 2023-09-05T20:21:44Z

a few comments, @svekars please merge if they get addressed

quick question. Is this a flaky CI error or the CI actually uses the latest pytorch stable (2.0)?

Unexpected failing examples:
/var/lib/jenkins/workspace/beginner_source/export_simple_model_to_onnx_tutorial.py failed leaving traceback:
Traceback (most recent call last):
  File "/var/lib/jenkins/workspace/beginner_source/export_simple_model_to_onnx_tutorial.py", line 83, in <module>
    export_output = torch.onnx.dynamo_export(net, input)
AttributeError: module 'torch.onnx' has no attribute 'dynamo_export'

I ask you that because torch.onnx does have dynamo_export in it. On main branch, one can import torch; print(dir(torch.onnx.dynamo_export)) and will succeed. Maybe the CI is not using pytorch main branch?

advanced_source/super_resolution_with_onnxruntime.py

requirements.txt

beginner_source/export_simple_model_to_onnx_tutorial.py

thiagocrepaldi · 2023-09-07T18:17:56Z

The CI issues is related to #1964

thiagocrepaldi · 2023-09-07T20:34:41Z

microsoft/onnxruntime#15855 might be the root cause for one of the failures

svekars

Some editorial suggestions. Let me know if you have any questions.

beginner_source/export_simple_model_to_onnx_tutorial.py

index.rst

thiagocrepaldi · 2023-09-13T21:44:47Z

cherry-picking the already approved #2550 to have a view of this tutorial after being referenced by the main ONNX page

svekars

Looks great! A couple editorial nits.

beginner_source/onnx/export_simple_model_to_onnx_tutorial.py

svekars · 2023-09-14T16:33:20Z

beginner_source/onnx/export_simple_model_to_onnx_tutorial.py

+# Although having the exported model loaded in memory is useful in many applications,
+# we can save it to disk with the following code:
+
+export_output.save("my_image_classifier.onnx")


will this work in the Google Colab?

is there a way to test with this pr preview? in theory, if the filesystem has read-write access, it should

I think you might need to mount a Google drive similar to this: https://pytorch.org/tutorials/beginner/colab.html#using-tutorial-data-from-google-drive-in-colab. Can maybe give a link to this section.

beginner_source/onnx/export_simple_model_to_onnx_tutorial.py

beginner_source/onnx/intro_onnx.py

svekars · 2023-09-14T16:45:30Z

beginner_source/onnx/intro_onnx.py

@@ -0,0 +1,59 @@
+"""
+**Introduction to ONNX** ||


Maybe consolidate all this in this PR: #2550?

That depends on when ONNX Runtime 1.16 will be released. This PR doesn't pass CI without it while #2550 does not need it.

I am monitoring the ort 1.16 release and will proceed as needed

@svekars ORT 1.16 is out and the CI issue seems to be gone

There is another unrelated one, though:

wget -nv 'https://docs.google.com/uc?export=download&id=1HJV2nUHJqclXQ8flKvcWmjZ-OU5DGatl' -O _data/lenet_mnist_model.pth https://docs.google.com/uc?export=download&id=1HJV2nUHJqclXQ8flKvcWmjZ-OU5DGatl: 2023-09-20 19:46:41 ERROR 429: Too Many Requests.

This PR adds a `Backends` section to the left menu which initially will initially contain a placeholder for the series of ONNX export tutorials based on Torch Dynamo backend A table of content tree page will have static URL https://pytorch.org/tutorials/beginner/onnx/intro_onnx.html that will be referenced on PyTorch user document for torch.onnx module

thiagocrepaldi · 2023-10-03T20:01:43Z

@svekars why was this closed?

facebook-github-bot added the cla signed label Sep 1, 2023

thiagocrepaldi force-pushed the thiagofc/add-onnx-tutorial branch 2 times, most recently from 65e8aa2 to 84105cd Compare September 1, 2023 21:55

svekars requested a review from msaroufim September 1, 2023 22:09

svekars added torch.compile Torch compile and other relevant tutorials onnx Issues relating to ONNX labels Sep 1, 2023

msaroufim reviewed Sep 2, 2023

View reviewed changes

beginner_source/export_simple_model_to_onnx_tutorial.py Outdated Show resolved Hide resolved

beginner_source/export_simple_model_to_onnx_tutorial.py Outdated Show resolved Hide resolved

beginner_source/export_simple_model_to_onnx_tutorial.py Outdated Show resolved Hide resolved

thiagocrepaldi requested a review from msaroufim September 5, 2023 16:15

abock suggested changes Sep 5, 2023

View reviewed changes

thiagocrepaldi force-pushed the thiagofc/add-onnx-tutorial branch from b5de6a4 to da79564 Compare September 5, 2023 18:31

thiagocrepaldi requested a review from abock September 5, 2023 18:42

thiagocrepaldi force-pushed the thiagofc/add-onnx-tutorial branch 3 times, most recently from dd9c264 to a3ce3e7 Compare September 5, 2023 18:46

justinchuby reviewed Sep 5, 2023

View reviewed changes

advanced_source/super_resolution_with_onnxruntime.py Outdated Show resolved Hide resolved

msaroufim approved these changes Sep 6, 2023

View reviewed changes

msaroufim reviewed Sep 6, 2023

View reviewed changes

requirements.txt Outdated Show resolved Hide resolved

This was referenced Sep 6, 2023

Refactor torch.onnx documentation pytorch/pytorch#108379

Closed

Test tutorials before the release #1964

Open

titaiwangms reviewed Sep 7, 2023

View reviewed changes

beginner_source/export_simple_model_to_onnx_tutorial.py Outdated Show resolved Hide resolved

thiagocrepaldi mentioned this pull request Sep 7, 2023

[ONNX 1] Add Backend section to the left page of Tutorials layout page #2550

Merged

svekars added the 2.1 label Sep 7, 2023

svekars changed the base branch from main to 2.1-RC-TEST September 7, 2023 18:28

thiagocrepaldi force-pushed the thiagofc/add-onnx-tutorial branch 3 times, most recently from 869f02a to 2c39bd4 Compare September 7, 2023 19:24

thiagocrepaldi force-pushed the thiagofc/add-onnx-tutorial branch from 2c39bd4 to 778623f Compare September 7, 2023 20:44

svekars reviewed Sep 8, 2023

View reviewed changes

thiagocrepaldi force-pushed the thiagofc/add-onnx-tutorial branch 2 times, most recently from 86b2c51 to 39395e6 Compare September 13, 2023 21:41

thiagocrepaldi changed the title ~~Add ONNX tutorial using torch.onnx.dynamo_export API~~ [ONNX 2] Add ONNX tutorial using torch.onnx.dynamo_export API Sep 13, 2023

titaiwangms mentioned this pull request Sep 13, 2023

[ONNX] Introduce ONNX Registry #2559

Closed

svekars reviewed Sep 14, 2023

View reviewed changes

thiagocrepaldi force-pushed the thiagofc/add-onnx-tutorial branch 3 times, most recently from 1d49848 to 9867f0e Compare September 14, 2023 17:36

titaiwangms mentioned this pull request Sep 14, 2023

[ONNX 3] Add ONNX registry tutorial #2562

Closed

Thiago Crepaldi added 2 commits September 20, 2023 15:35

Add ONNX tutorial using torch.onnx.dynamo_export API

8facb1e

thiagocrepaldi force-pushed the thiagofc/add-onnx-tutorial branch from 9867f0e to 8facb1e Compare September 20, 2023 19:35

svekars deleted the branch pytorch:2.1-RC-TEST October 2, 2023 19:54

svekars closed this Oct 2, 2023

titaiwangms mentioned this pull request Oct 3, 2023

Add ONNX registry tutorial #2578

Closed

This was referenced Oct 3, 2023

[ONNX 2] Add ONNX tutorial using torch.onnx.dynamo_export API #2580

Merged

[ONNX 3] Add ONNX registry tutorial #2595

Merged

[ONNX 2] Add ONNX tutorial using torch.onnx.dynamo_export API #2541

[ONNX 2] Add ONNX tutorial using torch.onnx.dynamo_export API #2541

Uh oh!

Conversation

thiagocrepaldi commented Sep 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2541

❌ 1 New Failure

Uh oh!

msaroufim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

abock left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thiagocrepaldi commented Sep 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thiagocrepaldi commented Sep 7, 2023

Uh oh!

thiagocrepaldi commented Sep 7, 2023

Uh oh!

svekars left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thiagocrepaldi commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

svekars left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

svekars Sep 14, 2023

Choose a reason for hiding this comment

Uh oh!

thiagocrepaldi Sep 14, 2023

Choose a reason for hiding this comment

Uh oh!

svekars Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

svekars Sep 14, 2023

Choose a reason for hiding this comment

Uh oh!

thiagocrepaldi Sep 14, 2023

Choose a reason for hiding this comment

Uh oh!

thiagocrepaldi Sep 21, 2023

thiagocrepaldi commented Sep 1, 2023 •

edited

Loading

pytorch-bot bot commented Sep 1, 2023 •

edited

Loading

thiagocrepaldi commented Sep 5, 2023 •

edited

Loading

thiagocrepaldi commented Sep 13, 2023 •

edited

Loading