Skip to content

Updating torchvision tutorial using Transforms API v2 #2533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

vfdev-5
Copy link
Contributor

@vfdev-5 vfdev-5 commented Aug 22, 2023

Description

  • Updating torchvision tutorial using Transforms API v2

TODO:

  • fix exec error with COCO eval (Update coco_utils.py vision#7869)
  • update _static/tv-training-code.py
  • update _static/torchvision_finetuning_instance_segmentation.ipynb or remove as unused and outdated? => decided to skip this and opt for sphinx gallery way of doing things.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @datumbox @nairbv @fmassa @NicolasHug @YosuaMichael

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 22, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2533

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 615bf83 with merge base 827843f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@svekars svekars added the module: vision Torchvision issues label Aug 22, 2023
@vfdev-5
Copy link
Contributor Author

vfdev-5 commented Aug 22, 2023

@svekars can please hint where the source of the notebook when we open it in colab: https://colab.research.google.com/github/pytorch/tutorials/blob/gh-pages/_downloads/torchvision_finetuning_instance_segmentation.ipynb ?

Seems like _static/torchvision_finetuning_instance_segmentation.ipynb is not used and looks very out-dated. We can remove it, maybe?

@vfdev-5 vfdev-5 force-pushed the update-tv-tutorial branch from 7db3973 to b538364 Compare August 23, 2023 11:14
@vfdev-5 vfdev-5 force-pushed the update-tv-tutorial branch from b538364 to 68089ab Compare August 23, 2023 13:05
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @vfdev-5 , I made a first pass but only have minor comments, this looks good

@vfdev-5 vfdev-5 marked this pull request as ready for review August 24, 2023 07:28
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vfdev-5 , the changes LGTM

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
@vfdev-5
Copy link
Contributor Author

vfdev-5 commented Aug 24, 2023

@svekars we are planning to rewrite this tutorial as a python file (same as a lot of other tutorials, e.g. https://github.com/pytorch/tutorials/blob/main/intermediate_source/spatial_transformer_tutorial.py) and rely on sphinx gallery to render the content and ipynb file.
Do you have any thoughts / suggestions about that, also concerning CI part ? For this tutorial we need to download the dataset, model weights and run the training/evaluation. Locally the training on recent GPUs takes less than 5 minutes (we can also reduce the number of epochs).

@vfdev-5 vfdev-5 merged commit bb82d43 into pytorch:main Aug 24, 2023
@vfdev-5 vfdev-5 deleted the update-tv-tutorial branch August 24, 2023 14:43
mikaylagawarecki pushed a commit to mikaylagawarecki/tutorials that referenced this pull request Sep 18, 2023
* Updated torchvision_tutorial.rst and _static/tv-training-code.py

* Addressed review comments

* Apply suggestions from code review

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>

---------

Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants