Skip to content

[BugFix] Fix Mario device error #2464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jun 13, 2023

Fixes the following error:

Unexpected failing examples:
/var/lib/jenkins/workspace/intermediate_source/mario_rl_tutorial.py failed leaving traceback:
Traceback (most recent call last):
  File "/var/lib/jenkins/workspace/intermediate_source/mario_rl_tutorial.py", line 760, in <module>
    q, loss = mario.learn()
  File "/var/lib/jenkins/workspace/intermediate_source/mario_rl_tutorial.py", line 600, in learn
    td_est = self.td_estimate(state, action)
  File "/var/lib/jenkins/workspace/intermediate_source/mario_rl_tutorial.py", line 494, in td_estimate
    current_Q = self.net(state, model="online")[
  File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/var/lib/jenkins/workspace/intermediate_source/mario_rl_tutorial.py", line 445, in forward
    return self.online(input)
  File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/container.py", line 217, in forward
    input = module(input)
  File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/conv.py", line 463, in forward
    return self._conv_forward(input, self.weight, self.bias)
  File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/conv.py", line 459, in _conv_forward
    return F.conv2d(input, weight, bias, self.stride,
  File "/opt/conda/lib/python3.10/site-packages/tensordict/memmap.py", line 417, in __torch_function__
    ret = func(*args, **kwargs)
RuntimeError: Input type (torch.FloatTensor) and weight type (torch.cuda.FloatTensor) should be the same or input should be a MKLDNN tensor and weight is a dense tensor

cc @nairbv

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 13, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2464

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 71ca300:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 71ca300
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/6488136a57390c0008b0b175
😎 Deploy Preview https://deploy-preview-2464--pytorch-tutorials-preview.netlify.app/intermediate/mario_rl_tutorial
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@svekars svekars added the rl label Jun 13, 2023
@svekars svekars merged commit ea0a11c into pytorch:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants