Skip to content

Update pyspelling to include beginner tutorials written in Python #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 11, 2023

Conversation

svekars
Copy link
Contributor

@svekars svekars commented Mar 31, 2023

  • Updated the .pyspelling config to exclude checking .rst code blocks, authors names, math and image directives
  • Expanded wordlist for beginner tutorials under beginner_source/*.py
  • Fix typos in these tutorials.
  • Renamed tutorials-worldlist to en-wordlist for consistency.

@netlify
Copy link

netlify bot commented Mar 31, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 5be438b
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/6435c15800e31a000841767a
😎 Deploy Preview https://deploy-preview-2279--pytorch-tutorials-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

kiersten-stokes and others added 5 commits March 31, 2023 16:46
* Change kernel to 5x5 in  1st Conv2d layer in model init

Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>

* Change kernel to 5x5 in 2nd Conv2d layer in model init

* Fix dimensions of 1st Linear layer to match new expected size

---------

Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
Co-authored-by: Suraj Subramanian <5676233+suraj813@users.noreply.github.com>
Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
@svekars svekars force-pushed the spellcheck-addons branch from ad27330 to 96fe703 Compare March 31, 2023 23:47
@svekars svekars requested a review from malfet March 31, 2023 23:47
en-wordlist.txt Outdated
NumPy
Numericalization
Numpy's
Numpy's
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be uniformly capitalized as NumPy's?

jpg
labelled
learnable
loadFilename
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be there, should it?

labelled
learnable
loadFilename
manualSeed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

pytorch
quantized
quantizing
randint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be there

reproducibility
rescale
rewinded
runtime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runtime

Comment on lines +30 to +32
# Ignore multiline content in codeblock
- open: '(?s)^::\n\n '
close: '^\n'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bad, it means that there are incorrectly offset codeblocks in the tutorials

@malfet malfet merged commit c2aa096 into main Apr 11, 2023
@malfet malfet deleted the spellcheck-addons branch April 11, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants