Skip to content

Standardise "Introduction to PyTorch" to use GPU, MPS or CPU #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 3, 2023

Conversation

alvaropp
Copy link
Contributor

@alvaropp alvaropp commented Mar 30, 2023

The quickstart tutorial does try to use GPU/MPS if available. Later, the Build the Neural Network tutorial only looks for GPU.

This got me confused for while as I went back to find the code to select MPS and couldn't find it, and I reckon it's better to have these two tutorials be consistent.

cc @malfet @albanD @kulinseth @razarmehr

@netlify
Copy link

netlify bot commented Mar 30, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 3c079ba
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/64271532181f2e00081d8445
😎 Deploy Preview https://deploy-preview-2276--pytorch-tutorials-preview.netlify.app/intermediate/reinforcement_ppo
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@svekars svekars requested a review from malfet March 30, 2023 18:28
@svekars svekars added the mps Apple M1 / MPS related changes label Mar 30, 2023
Copy link

@kulinseth kulinseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good.

@malfet malfet merged commit 600e14a into pytorch:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed mps Apple M1 / MPS related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants