Skip to content

Add shapes tutorial #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2023
Merged

Add shapes tutorial #2267

merged 2 commits into from
Mar 27, 2023

Conversation

mikaylagawarecki
Copy link
Contributor

Tutorial for pytorch/pytorch#97118

@netlify
Copy link

netlify bot commented Mar 24, 2023 •
edited
Loading

✅ Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit a104f6d
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/642201257ecb340008e8a209
😎 Deploy Preview https://deploy-preview-2267--pytorch-tutorials-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

svekars
svekars reviewed Mar 24, 2023
View reviewed changes
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of very minor nits.

@svekars svekars requested a review from albanD March 24, 2023 18:02
@svekars svekars added the core Tutorials of any level of difficulty related to the core pytorch functionality label Mar 24, 2023
@mikaylagawarecki mikaylagawarecki force-pushed the shape_tutorial branch 3 times, most recently from 31d65c5 to 0c1f294 Compare March 24, 2023 20:04
jbschlosser
jbschlosser approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! It reads really well IMO.

Just a couple formatting / flow nits but otherwise solid :)

albanD
albanD reviewed Mar 24, 2023
View reviewed changes
Copy link
Contributor

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Only small comment!

@mikaylagawarecki mikaylagawarecki force-pushed the shape_tutorial branch 3 times, most recently from da6a9e0 to d5678c2 Compare March 27, 2023 15:18
albanD
albanD approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@svekars svekars merged commit c941e50 into pytorch:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svekars svekars svekars approved these changes

@albanD albanD albanD approved these changes

@jbschlosser jbschlosser jbschlosser approved these changes

Assignees
No one assigned
Labels
cla signed core Tutorials of any level of difficulty related to the core pytorch functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikaylagawarecki @svekars @albanD @jbschlosser @facebook-github-bot