Skip to content

Include introyt/trainingyt tutorial in the build #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

bjhargrave
Copy link
Contributor

@bjhargrave bjhargrave commented Mar 2, 2023

Include introyt/trainingyt tutorial in the build

The tutorial was not being built and published on the website.
So fixes such as 7d8cb43 were not then visible on the website since old
output files are still present.

@netlify
Copy link

netlify bot commented Mar 2, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 3819a52
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/64026cecf73b46000753dd9a
😎 Deploy Preview https://deploy-preview-2232--pytorch-tutorials-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@svekars
Copy link
Contributor

svekars commented Mar 2, 2023

@bjhargrave thank you for submitting this request. As you can see here and here both tutorials are failing on build. To be able to enable them, we need to fix these errors first.

@svekars svekars added the build issue Issues relating to the tutorials build label Mar 2, 2023
@bjhargrave bjhargrave force-pushed the include-in-build branch 3 times, most recently from 960a274 to d78b2ab Compare March 3, 2023 20:41
The tutorial was not being built and published on the website.
So fixes such as 7d8cb43 were not then visible on the website since old
output files are still present.

Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
@bjhargrave bjhargrave changed the title Include all introyt tutorials in the build Include introyt/trainingyt tutorial in the build Mar 3, 2023
@svekars svekars merged commit f42a7ab into pytorch:main Mar 3, 2023
@bjhargrave bjhargrave deleted the include-in-build branch March 4, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build issue Issues relating to the tutorials build cla signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants