Skip to content

Replace the out of date super init method #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Replace the out of date super init method #2211

merged 2 commits into from
Feb 24, 2023

Conversation

yingshaoxo
Copy link
Contributor

According to this docs: https://github.com/pytorch/pytorch/blob/master/torch/nn/modules/module.py#L379

We should use super().__init__() than Super(NeuralNetwork, self).__init__()

According to this docs: https://github.com/pytorch/pytorch/blob/master/torch/nn/modules/module.py#L379

We should use `super().__init__()` than `Super(NeuralNetwork, self).__init__()`
@facebook-github-bot
Copy link
Contributor

Hi @yingshaoxo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify
Copy link

netlify bot commented Feb 21, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit f3ed43f
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/63f92cd495b8ff0008bc387f
😎 Deploy Preview https://deploy-preview-2211--pytorch-tutorials-preview.netlify.app/beginner/basics/buildmodel_tutorial
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@svekars svekars merged commit d970640 into pytorch:main Feb 24, 2023
clee2000 pushed a commit to clee2000/tutorials that referenced this pull request Feb 28, 2023
According to this docs: https://github.com/pytorch/pytorch/blob/master/torch/nn/modules/module.py#L379

We should use `super().__init__()` than `Super(NeuralNetwork, self).__init__()`

Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants