Skip to content

Fix minor typos, grammar, and formatting errors in the DDP video series #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

kiersten-stokes
Copy link
Contributor

@kiersten-stokes kiersten-stokes commented Feb 7, 2023

As stated in title, this PR fixes a handful of small mistakes in the DDP video series tutorial. It also adds clarification on what GIL is in the theory page (for those of us new to the concepts 🙂).

Great, tutorial, by the way! Very clear and easy to follow along.

cc @svekars @carljparker

@netlify
Copy link

netlify bot commented Feb 7, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 46c4a10
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/63e2c8d245331200084281cd
😎 Deploy Preview https://deploy-preview-2197--pytorch-tutorials-preview.netlify.app/beginner/ddp_series_fault_tolerance
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@svekars svekars added the grammar label Feb 7, 2023
@svekars svekars requested a review from subramen February 7, 2023 21:33
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One minor nit. Thank you for fixing this!

@svekars svekars merged commit 9ec2625 into pytorch:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants