Skip to content

Redirect audio tutorials to torchaudio #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2023
Merged

Redirect audio tutorials to torchaudio #2154

merged 2 commits into from
Feb 24, 2023

Conversation

mthrok
Copy link
Contributor

@mthrok mthrok commented Dec 13, 2022

No description provided.

@netlify
Copy link

netlify bot commented Dec 13, 2022 •
edited
Loading

✅ Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit ba02876
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/63f82369524199000859f9dd
😎 Deploy Preview https://deploy-preview-2154--pytorch-tutorials-preview.netlify.app/beginner/blitz/autograd_tutorial
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mthrok mthrok marked this pull request as ready for review February 17, 2023 03:38
@mthrok mthrok requested a review from svekars February 21, 2023 23:02
@svekars
Copy link
Contributor

svekars commented Feb 22, 2023

I think we should add all of the tutorials that we are redirecting to the this list: https://github.com/pytorch/tutorials/blob/main/.jenkins/validate_tutorials_built.py#L11 with a comment that these files are redirects now.

@carljparker
Copy link
Contributor

I think we should add all of the tutorials that we are redirecting to the this list: https://github.com/pytorch/tutorials/blob/main/.jenkins/validate_tutorials_built.py#L11 with a comment that these files are redirects now.

If we add the redirected tutorials to that file, will the all the CircleCI checks pass? Is that the reason that some of them are not passing?

@svekars
Copy link
Contributor

svekars commented Feb 22, 2023

yes, the check fails as expected. Adding to the NOT RUN list will fix it.

@mthrok mthrok changed the title Redirect TTS tutorial to torchaudio Redirect audio tutorials to torchaudio Feb 23, 2023
svekars
svekars reviewed Feb 23, 2023
View reviewed changes
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things to fix to ensure the html is not broken. I commented on one but applies to all files.

beginner_source/audio_data_augmentation_tutorial.rst Outdated
It will redirect in 3 seconds.
.. raw::html
<meta http-equiv="Refresh" content="3; url='https://pytorch.org/audio/stable/tutorials/audio_data_augmentation_tutorial.html'" />
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""

beginner_source/audio_data_augmentation_tutorial.rst Outdated
@@ -0,0 +1,11 @@
# -*- coding: utf-8 -*-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# -*- coding: utf-8 -*-

beginner_source/audio_data_augmentation_tutorial.rst Outdated
@@ -0,0 +1,11 @@
# -*- coding: utf-8 -*-
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""

beginner_source/audio_data_augmentation_tutorial.rst Outdated
This tutorial has been moved to https://pytorch.org/audio/stable/tutorials/audio_data_augmentation_tutorial.html

It will redirect in 3 seconds.
.. raw::html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. raw::html
.. raw:: html

svekars
svekars approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@svekars svekars merged commit d73d23e into pytorch:main Feb 24, 2023
@mthrok mthrok deleted the redirect-tts branch March 1, 2023 21:51
malfet added a commit that referenced this pull request Oct 4, 2023
@malfet
[BE] Do not download audio assets
6187798 
Followup after #2154 that moved audio tutorials to another repo
- Do not install `torchaudio`
- Do not download `UrbanSound8K.tar.gz` which 5+Gb
@malfet malfet mentioned this pull request Oct 4, 2023
Merged
malfet added a commit that referenced this pull request Oct 4, 2023
@malfet
[BE] Do not download audio assets (#2584)
587c62a 
Followup after #2154 that moved audio tutorials to another repo
- Do not install `torchaudio`
- Do not download `UrbanSound8K.tar.gz`, which is 5+Gb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svekars svekars svekars approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mthrok @svekars @carljparker @facebook-github-bot