Skip to content

Assist users in contributing new tutorials #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 13, 2022
Merged

Conversation

carljparker
Copy link
Contributor

Major update to assist user in contributing new tutorials.

Major update to assist user in contributing new tutorials.
@netlify
Copy link

netlify bot commented Dec 9, 2022

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 16ae2db
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/6398cbda082c4800093ae9d6
😎 Deploy Preview https://deploy-preview-2148--pytorch-tutorials-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple of questions / comments.

a result of, for example, updates to Python or PyTorch or other
packages. If your tutorial fails to build in our Continuous Integration
(CI) system, we might contact you in order to resolve the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably say that something like: If your tutorial relies on dependancies not defined in the requirements.txt file, you can add them there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added this text to the beginning of this section, so that they add any extra packages they need to requirements.txt.

CONTRIBUTING.md Outdated
take the tutorial off the site.


# Guidance for authoring tutorials and recipes #
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need that "#" at the end of the line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-P . . . No, the trailing hash marks are optional; it is just a habit that I am in when writing Markdown. They are there in all the headers that I added . . . :-P . . . I don't want to change all of them right now because I am concerned that in making a bunch of edits, I might disrupt something else in the file. The trailing hash marks are not visible when the file renders, so my preference is to merge the current version and then remove the hash marks in some future PR.

## Test Your Tutorial Locally ##

The following command builds an HTML version of the tutorial website.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to enclose in ```

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, added the enclosing backquotes.

@svekars
Copy link
Contributor

svekars commented Dec 13, 2022

LGTM!

@svekars svekars merged commit a585992 into master Dec 13, 2022
@svekars svekars deleted the carljparker-contributing-1 branch December 13, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants