Skip to content

[Quant] Add tutorial for BackendConfig #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

andrewor14
Copy link
Contributor

@andrewor14 andrewor14 commented Nov 21, 2022

Summary: This commit adds the tutorial for the BackendConfig,
the integration point for backend developers to specify the
quantization behavior on a given target backend.

Note to reviewers: To see the rendered version, just go to
"Files changed" > "..." > "View file".

Reviewers: jerryzh168, vkuzo

Subscribers: jerryzh168, vkuzo

@netlify
Copy link

netlify bot commented Nov 21, 2022

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 2cfa298
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/639c9b707c0802000846568a
😎 Deploy Preview https://deploy-preview-2124--pytorch-tutorials-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@andrewor14 andrewor14 force-pushed the backend-config branch 5 times, most recently from c8e2819 to e0b2159 Compare November 21, 2022 18:18
Copy link
Contributor

@vkuzo vkuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tutorial looks good, but requesting changes for cleaning up the user API. I think we need to make sure this is user friendly before going further.

@andrewor14
Copy link
Contributor Author

andrewor14 commented Dec 15, 2022

Ok, I updated the tutorial to use the simple format now that pytorch/pytorch#90698 is merged. This should address the comments from the last round of review. Please have a look @vkuzo and @jerryzh168.

@andrewor14 andrewor14 requested review from jerryzh168 and vkuzo and removed request for vkuzo and jerryzh168 December 19, 2022 17:07
Copy link
Contributor

@vkuzo vkuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, but I think we should clarify what DType means here

@andrewor14 andrewor14 force-pushed the backend-config branch 2 times, most recently from 0e7fa4e to 03c3c73 Compare December 22, 2022 19:54
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, one comment about adding more docs to talk about the process of how people come up with BackendPatternConfig for each op

@andrewor14 andrewor14 force-pushed the backend-config branch 2 times, most recently from 9b16bd5 to 2a81bfc Compare December 22, 2022 22:53
Summary: This commit adds the tutorial for the BackendConfig,
the integration point for backend developers to specify the
quantization behavior on a given target backend.

Note to reviewers: To see the rendered version, just go to
"Files changed" > "..." > "View file".

Reviewers: jerryzh168, vkuzo

Subscribers: jerryzh168, vkuzo
@andrewor14
Copy link
Contributor Author

Ok, I think I addressed all the comments. Thank you both for your feedback! I'm merging this.

@andrewor14
Copy link
Contributor Author

@pytorchbot merge

@andrewor14
Copy link
Contributor Author

Hi @svekars, could you help me merge this? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants