-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[Quant] Add tutorial for BackendConfig #2124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for pytorch-tutorials-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
c8e2819
to
e0b2159
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the tutorial looks good, but requesting changes for cleaning up the user API. I think we need to make sure this is user friendly before going further.
e0b2159
to
967ae6b
Compare
967ae6b
to
2408739
Compare
Ok, I updated the tutorial to use the simple format now that pytorch/pytorch#90698 is merged. This should address the comments from the last round of review. Please have a look @vkuzo and @jerryzh168. |
2408739
to
2cfa298
Compare
868eec5
to
3cf5283
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg, but I think we should clarify what DType means here
2a398d2
to
15b1e1e
Compare
0e7fa4e
to
03c3c73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg, one comment about adding more docs to talk about the process of how people come up with BackendPatternConfig for each op
9b16bd5
to
2a81bfc
Compare
Summary: This commit adds the tutorial for the BackendConfig, the integration point for backend developers to specify the quantization behavior on a given target backend. Note to reviewers: To see the rendered version, just go to "Files changed" > "..." > "View file". Reviewers: jerryzh168, vkuzo Subscribers: jerryzh168, vkuzo
05a54af
to
8b13925
Compare
Ok, I think I addressed all the comments. Thank you both for your feedback! I'm merging this. |
@pytorchbot merge |
Hi @svekars, could you help me merge this? Thanks. |
Summary: This commit adds the tutorial for the BackendConfig,
the integration point for backend developers to specify the
quantization behavior on a given target backend.
Note to reviewers: To see the rendered version, just go to
"Files changed" > "..." > "View file".
Reviewers: jerryzh168, vkuzo
Subscribers: jerryzh168, vkuzo