Skip to content

update for ipex gpu release #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 7, 2022
Merged

update for ipex gpu release #2118

merged 4 commits into from
Dec 7, 2022

Conversation

jingxu10
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 8726706
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/638fa6a6c0a65700087b46d0
😎 Deploy Preview https://deploy-preview-2118--pytorch-tutorials-preview.netlify.app/recipes/intel_extension_for_pytorch
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor suggestions. Thank you!

$ make

If Found INTEL_EXT_PT_CPU is shown as TRUE, the extension had been linked into
the binary. This can be verified with Linux command ldd.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the binary. This can be verified with Linux command ldd.
the binary. This can be verified with the Linux command `ldd`.

$ make

If Found INTEL_EXT_PT_CPU is shown as TRUE, the extension had been linked into
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If Found INTEL_EXT_PT_CPU is shown as TRUE, the extension had been linked into
If Found `INTEL_EXT_PT_CPU` is shown as `TRUE`, the extension had been linked into

Should Found be uppercase?


Use cases that had already been optimized by Intel engineers are available at
`Model Zoo for Intel® Architecture <https://github.com/IntelAI/models/>`_ (with
branch name in format of `pytorch-r<version>-models`). A bunch of PyTorch use
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
branch name in format of `pytorch-r<version>-models`). A bunch of PyTorch use
the branch name in format of `pytorch-r<version>-models`). Many PyTorch use

`Model Zoo for Intel® Architecture <https://github.com/IntelAI/models/>`_ (with
branch name in format of `pytorch-r<version>-models`). A bunch of PyTorch use
cases for benchmarking are also available on the GitHub page. You can get
performance benefits out-of-box by simply running scipts in the Model Zoo.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
performance benefits out-of-box by simply running scipts in the Model Zoo.
performance benefits out-of-the-box by simply running scripts in the Model Zoo.

Tutorials
---------

Please visit `Intel® Extension for PyTorch* Github repo <https://github.com/intel/intel-extension-for-pytorch>`_ for more tutorials.
More detailed tutorials are available at Github.io for `CPU <https://intel.github.io/intel-extension-for-pytorch/cpu/latest/>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it say something like this:

are available in the official Intel® Extension for PyTorch* Documentation: 

* `CPU tutorials <https://intel.github.io/intel-extension-for-pytorch/cpu/latest/>`__ 
* `GPU tutorials <https://intel.github.io/intel-extension-for-pytorch/xpu/latest/>`__

@jingxu10
Copy link
Contributor Author

updated.

@jingxu10
Copy link
Contributor Author

May I know the status of this PR?

@svekars
Copy link
Contributor

svekars commented Dec 2, 2022

Thanks for addressing all feedback, approved and will merge after it passes CI.

@svekars svekars merged commit d0b1326 into pytorch:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants