Skip to content

Update gym to v0.26.1 #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Update gym to v0.26.1 #2069

wants to merge 4 commits into from

Conversation

svekars
Copy link
Contributor

@svekars svekars commented Oct 6, 2022

No description provided.

@svekars svekars changed the title Update gym too v0.26.1 Update gym to v0.26.1 Oct 6, 2022
@netlify
Copy link

netlify bot commented Oct 6, 2022

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 07ca6d5
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/633f170cbe666c0008dd8ff2
😎 Deploy Preview https://deploy-preview-2069--pytorch-tutorials-preview.netlify.app/intermediate/mario_rl_tutorial
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make necessary changes (which should be minimal) to the tutorial rather than just disable it

Copy link

@arjun-kg arjun-kg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I believe more changes are needed wrt to the mario tutorial. I'm unable to comment inline for some of them so I'll add them here -

  1. The nes-py environment it depends on has not been updated to 0.26. We can use a compatibility wrapper in the meantime, and change the make statement like below -
env = gym_super_mario_bros.make("SuperMarioBros-1-1-v0", apply_api_compatibility=True)
  1. env.reset() now returns two values, please change the reset statement to to
    state, _ = env.reset()

  2. Please replace any place that has 4 step returns (obs, reward, done, info), to 5 step returns (obs, reward, terminated, truncated, info)

  3. The replay buffer should hold terminated instead of done. It would be more clear if we replaced done with terminated in all the references with respect to replay buffer, and bootstrapping.

  4. In places where episode end is checked, please change if done to if (terminated or truncated)

@pseudo-rnd-thoughts
Copy link
Contributor

Hey, is there any progress on this PR? Im happy to finish it if necessary

@svekars
Copy link
Contributor Author

svekars commented Dec 2, 2022

I'm closing this for now and this will be handled separately.

@svekars svekars closed this Dec 2, 2022
@jkterry1
Copy link

jkterry1 commented Jan 3, 2023

@svekars is there a new PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants