-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Update gym to v0.26.1 #2069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gym to v0.26.1 #2069
Conversation
✅ Deploy Preview for pytorch-tutorials-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make necessary changes (which should be minimal) to the tutorial rather than just disable it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. I believe more changes are needed wrt to the mario tutorial. I'm unable to comment inline for some of them so I'll add them here -
- The
nes-py
environment it depends on has not been updated to 0.26. We can use a compatibility wrapper in the meantime, and change the make statement like below -
env = gym_super_mario_bros.make("SuperMarioBros-1-1-v0", apply_api_compatibility=True)
-
env.reset()
now returns two values, please change the reset statement to to
state, _ = env.reset()
-
Please replace any place that has 4 step returns (obs, reward, done, info), to 5 step returns (obs, reward, terminated, truncated, info)
-
The replay buffer should hold
terminated
instead ofdone
. It would be more clear if we replaceddone
withterminated
in all the references with respect to replay buffer, and bootstrapping. -
In places where episode end is checked, please change
if done
toif (terminated or truncated)
Hey, is there any progress on this PR? Im happy to finish it if necessary |
I'm closing this for now and this will be handled separately. |
@svekars is there a new PR for this? |
No description provided.