Skip to content

Convert docstring to literal and fix math rendering typo #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 9, 2021
Merged

Convert docstring to literal and fix math rendering typo #1739

merged 3 commits into from
Nov 9, 2021

Conversation

weston-barger
Copy link
Contributor

pytorch/pytorch#67772 (comment)

Added missing \ to \pi.

Converted docstring of beginner_source/examples_autograd/polynomial_custom_function.py to literal because \f and \r were being resolved as escapes before math rendering.

@netlify
Copy link

netlify bot commented Nov 5, 2021

✔️ Deploy Preview for pytorch-tutorials-preview ready!

🔨 Explore the source changes: afea296

🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/618ac8cfcc415a000792088f

😎 Browse the preview: https://deploy-preview-1739--pytorch-tutorials-preview.netlify.app

@soulitzer soulitzer self-requested a review November 8, 2021 19:23
Copy link
Contributor

@soulitzer soulitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix!

@weston-barger
Copy link
Contributor Author

Thanks @soulitzer! This is my first github pull request :). Is there anything else that I need to do?

@soulitzer
Copy link
Contributor

Nope, I think we should be good to go. Just waiting for the tests to run again before it can be merged.

@soulitzer soulitzer merged commit c08519b into pytorch:master Nov 9, 2021
rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants