Skip to content

Update rpc_tutorial "Getting Started with Distributed RPC Framework" #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2021

Conversation

H-Huang
Copy link
Member

@H-Huang H-Huang commented Apr 19, 2021

Clean up helper method which aren't need anymore and changed the hyperparameters (train steps, gamma) to allow the agent to train to completion

Currents docs: https://pytorch.org/tutorials/intermediate/rpc_tutorial.html
New docs preview: https://h-huang.github.io/tutorials/intermediate/rpc_tutorial.html

@netlify
Copy link

netlify bot commented Apr 19, 2021

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 9bd6157

https://deploy-preview-1474--pytorch-tutorials-preview.netlify.app

Copy link

@zhaojuanmao zhaojuanmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, please see one minor comment

Comment on lines -339 to -340
n_steps = int(TOTAL_EPISODE_STEP / (args.world_size - 1))
agent.run_episode(n_steps=n_steps)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel it is useful to understand how n_steps are divided/parallelized when I read this tutorial

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, it is also mentioned in the descriptions so I will add it back in. The reason I changed it was because the default value was too small so the trainer wasn't making any progress; I will just increase the default val.

@brianjo brianjo merged commit 58f7386 into pytorch:master Apr 20, 2021
rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
Co-authored-by: Brian Johnson <brianjo@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants