-
Notifications
You must be signed in to change notification settings - Fork 4.2k
non-colab recording in speech tutorial #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d_recognition_with_torchaudio_tutorial.py Updated to run the tutorial at build time.
This reverts commit 4f30a8a.
Deploy preview for pytorch-tutorials-preview ready! Built with commit 90fb006 https://deploy-preview-1252--pytorch-tutorials-preview.netlify.app |
@@ -525,6 +525,32 @@ def record(seconds=1): | |||
return torchaudio.load(filename) | |||
|
|||
|
|||
def record_noncolab(seconds=1): | |||
|
|||
import sounddevice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounddevice needs to be installed in the environment for this to work
(Fixed a couple of issues in master, so I merged them into this PR.) |
Hi @vincentqb! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 similar comment
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Follow up to #1223 to add non-colab recording.