Skip to content

Update beginner_source/README.txt #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update beginner_source/README.txt #1219

wants to merge 1 commit into from

Conversation

jaketae
Copy link
Contributor

@jaketae jaketae commented Nov 5, 2020

This PR updates/corrects the link to the PyTorch transformer translation tutorial.

@facebook-github-bot
Copy link
Contributor

Hi @jaketae!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Nov 5, 2020

Deploy preview for pytorch-tutorials-preview ready!

Built with commit f580f17

https://deploy-preview-1219--pytorch-tutorials-preview.netlify.app

@bigfootjon bigfootjon closed this Feb 16, 2021
@bigfootjon bigfootjon deleted the branch pytorch:master February 16, 2021 19:37
@jaketae
Copy link
Contributor Author

jaketae commented Feb 17, 2021

Hey @bigfootjon, master still appears to have an obsolete link to the tutorial. I'm curious to know why this PR was closed? This seems like a very small, trivial change to me, but of course there might be details I'm missing. Thanks!

@bigfootjon
Copy link
Member

Hi @jaketae, this was mistakenly closed due to a mixup with the default branch name. Unfortunately, I can't reopen the PR because the old master branch was deleted. Please create a new PR and reference this PR.

@jaketae
Copy link
Contributor Author

jaketae commented Feb 18, 2021

@bigfootjon Will do, I appreciate the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants