Skip to content

iOS and Android image segmentation tutorials; minor recipes code and typo fix for 1.7 #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Nov 12, 2020

Conversation

jeffxtang
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Oct 27, 2020

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 2ddc8cc

https://deploy-preview-1213--pytorch-tutorials-preview.netlify.app

@jeffxtang jeffxtang marked this pull request as draft October 31, 2020 18:03
@chauhang
Copy link

@jeffxtang Please split into 2 separate PRs. One for the typos fixes and minor edits, and other for the new content


5. Complete the UI, refactor, build and run the app to see image segmentation in action.

Pre-requisites

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Pre-requisites
Prerequisites


5. Complete the UI, refactor, build and run the app to see image segmentation in action.

Pre-requisites

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Pre-requisites
Prerequisites

Comment on lines +33 to +37
* PyTorch 1.6 or 1.7

* torchvision 0.7 or 0.8

* Xcode 11 or 12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use "version X or later" instead. (e.g. PyTorch 1.6 or later)

Pre-requisites
---------------

* PyTorch 1.6 or 1.7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use "version X or later" instead. (e.g. PyTorch 1.6 or later)

@jeffxtang jeffxtang changed the title recipes code and typo fix on 1.7 recipes code and typo fix for 1.7 + iOS and Android image segmentation tutorials Nov 5, 2020
@jeffxtang jeffxtang changed the title recipes code and typo fix for 1.7 + iOS and Android image segmentation tutorials recipes code and typo fix for 1.7; iOS and Android image segmentation tutorials Nov 5, 2020
@jeffxtang jeffxtang changed the title recipes code and typo fix for 1.7; iOS and Android image segmentation tutorials iOS and Android image segmentation tutorials; minor recipes code and typo fix for 1.7 Nov 5, 2020
@jeffxtang jeffxtang marked this pull request as ready for review November 11, 2020 19:37
@brianjo brianjo merged commit 65778b9 into pytorch:master Nov 12, 2020
rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
…typo fix for 1.7 (pytorch#1213)

* pt mobile script and optimize recipe

* 1 pt mobile new recipes summary and 5 recipes

* updated recipes_index.rst

* thumbnail png fix for ios recipe in recipes_index.rst

* edits based on feedback

* recipes code and typo fix on 1.7

* merge from master

* fixed merge errors

* added limitation warning for dynamic quantization

* link fix for quantization and model prep for ios recipes

* deeplabv3_on_ios tutorial

* more edits on the ios segmentation tutorial

* image segmentation android tutorial

* ios segmentation tutorial update

* code refactoring on code coloring; added reviewed by

* updated android deeplabv3 tutorial

* further update on the iOS and Android segmentation tutorials

* minor and maybe final edits for two tutorials

Co-authored-by: Brian Johnson <brianjo@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants