[iOS][GPU] Add iOS GPU workflow #1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffxtang
reviewed
Oct 22, 2020
| - Eskimo dog, husky | ||
|
|
||
| You may notice that the results are slighly different from the `results <https://pytorch.org/mobile/ios/#install-libtorch-via-cocoapods>`_ we got from the CPU model as shown in the iOS tutorial. This is because by default Metal uses fp16 rather than fp32 to compute. The precision loss is expected. | ||
|
|
There was a problem hiding this comment.
Should we point to the GPU performance gain results at pytorch/pytorch#46600 or do a quick summary here?
|
|
||
| IOS_ARCH=arm64 USE_PYTORCH_METAL=1 ./scripts/build_ios.sh | ||
|
|
||
| Note ``IOS_ARCH`` tells the script to build a arm64 version of Libtorch. This is because in PyTorch, Metal is only available for the iOS devices that support the Apple A9 chip or above. Once the build finished, follow the `Build PyTorch iOS libraries from source <https://pytorch.org/mobile/ios/#build-pytorch-ios-libraries-from-source>`_ section from the iOS tutorial to setup the XCode settings properly. Don't forget to copy the `./mobilenetv2_metal.pt` to your XCode project. |
There was a problem hiding this comment.
Please see if the comment in the link below makes sense? https://github.com/pytorch/tutorials/pull/1191/files/77db29b7559ecf29e611e833e34dfb3127fc2ba6#r509812268
| IOS_ARCH=arm64 USE_PYTORCH_METAL=1 ./scripts/build_ios.sh | ||
|
|
||
| Note ``IOS_ARCH`` tells the script to build a arm64 version of Libtorch. This is because in PyTorch, Metal is only available for the iOS devices that support the Apple A9 chip or above. Once the build finished, follow the `Build PyTorch iOS libraries from source <https://pytorch.org/mobile/ios/#build-pytorch-ios-libraries-from-source>`_ section from the iOS tutorial to setup the XCode settings properly. Don't forget to copy the `./mobilenetv2_metal.pt` to your XCode project. | ||
|
|
There was a problem hiding this comment.
In TorchModule.mm we also need to change one line to make the build work:
//#import <LibTorch/LibTorch.h>
#import <torch/script.h>
brianjo
added a commit
that referenced
this pull request
Oct 27, 2020
* [iOS][GPU] Add iOS GPU workflow (#1200) * pt mobile script and optimize recipe (#1193) * pt mobile script and optimize recipe * 1 pt mobile new recipes summary and 5 recipes * updated recipes_index.rst * thumbnail png fix for ios recipe in recipes_index.rst * edits based on feedback * Updating 1.7 branch (#1205) * Update event tracking (#1188) * Update beginner_source/audio_preprocessing_tutorial.py (#1199) * Typo in beginner_source/audio_preprocessing_tutorial.py Typo in beginner_source/audio_preprocessing_tutorial.py fron > from * update title. * fix file access. Co-authored-by: JuHyuk Park <creduo@gmail.com> * Update audio_preprocessing_tutorial.py (#1202) Adds a comment for running this tutorial in Google Colab. Co-authored-by: Pat Mellon <16585245+patmellon@users.noreply.github.com> Co-authored-by: Vincent QB <vincentqb@users.noreply.github.com> Co-authored-by: JuHyuk Park <creduo@gmail.com> Co-authored-by: Tao Xu <taox@fb.com> Co-authored-by: Jeff Tang <jeffxtang@fb.com> Co-authored-by: Pat Mellon <16585245+patmellon@users.noreply.github.com> Co-authored-by: Vincent QB <vincentqb@users.noreply.github.com> Co-authored-by: JuHyuk Park <creduo@gmail.com>
rodrigo-techera
pushed a commit
to Experience-Monks/tutorials
that referenced
this pull request
Nov 29, 2021
* [iOS][GPU] Add iOS GPU workflow (pytorch#1200) * pt mobile script and optimize recipe (pytorch#1193) * pt mobile script and optimize recipe * 1 pt mobile new recipes summary and 5 recipes * updated recipes_index.rst * thumbnail png fix for ios recipe in recipes_index.rst * edits based on feedback * Updating 1.7 branch (pytorch#1205) * Update event tracking (pytorch#1188) * Update beginner_source/audio_preprocessing_tutorial.py (pytorch#1199) * Typo in beginner_source/audio_preprocessing_tutorial.py Typo in beginner_source/audio_preprocessing_tutorial.py fron > from * update title. * fix file access. Co-authored-by: JuHyuk Park <creduo@gmail.com> * Update audio_preprocessing_tutorial.py (pytorch#1202) Adds a comment for running this tutorial in Google Colab. Co-authored-by: Pat Mellon <16585245+patmellon@users.noreply.github.com> Co-authored-by: Vincent QB <vincentqb@users.noreply.github.com> Co-authored-by: JuHyuk Park <creduo@gmail.com> Co-authored-by: Tao Xu <taox@fb.com> Co-authored-by: Jeff Tang <jeffxtang@fb.com> Co-authored-by: Pat Mellon <16585245+patmellon@users.noreply.github.com> Co-authored-by: Vincent QB <vincentqb@users.noreply.github.com> Co-authored-by: JuHyuk Park <creduo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.