Update tutorials to use TensorPipeRpcBackendOptions. #1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for pytorch-tutorials-preview ready! Built with commit d16fc60 https://deploy-preview-1164--pytorch-tutorials-preview.netlify.app |
rohan-varma
approved these changes
Sep 22, 2020
There was a problem hiding this comment.
Thanks! I'm assuming we would need @lw's PR for inferring the right type of backend for this to work properly?
|
Thanks for doing this! That PR is in pytorch/pytorch#45065, and it's ready for review. |
I think this would work without the PR since we've updated the tutorials to use the right options when the default is TensorPipe. |
|
Landing this since we decided to go with TensorPipe as the default backend. |
subramen
pushed a commit
to subramen/tutorials
that referenced
this pull request
Feb 1, 2021
* Update tutorials to use TensorPipeRpcBackendOptions. * Commit Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Commit2 Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Co-authored-by: pritam <pritam.damania@fb.com>
cassiebreviu
added a commit
to sethjuarez/tutorials
that referenced
this pull request
Feb 1, 2021
* refactor - till custom datasets * Updated data * updated buildmodel * update the other sections * final edits * A fix for one line comment when removing runnable code. (pytorch#1165) Co-authored-by: v-jizhang <66389669+buck-bot@users.noreply.github.com> * Update tutorials to use TensorPipeRpcBackendOptions. (pytorch#1164) * Update tutorials to use TensorPipeRpcBackendOptions. * Commit Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Commit2 Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Co-authored-by: pritam <pritam.damania@fb.com> * Update dynamic quant tutorial for saving quantized model (pytorch#1167) Summary: Addresses pytorch/pytorch#43016 Test Plan: Reviewers: Subscribers: Tasks: Tags: * retitle dispatcher tutorial (pytorch#1168) * minor typo fixes (pytorch#1160) Co-authored-by: Brian Johnson <brianjo@fb.com> * Update saving_loading_models.py (pytorch#1173) * Removes Outdated Trainer Tutorial (pytorch#1181) * Update index.rst * Delete aws_distributed_training_tutorial.py * complete PyTorch quickstart proposal * Formatting and wording updates (#27) * corrected rebase errors * Some updates based on feedback to quickstart and build model (#29) * Added more detail to the intro of the quickstart * primitive dataset text update * fix build model * updated quickstart to class model (#30) * fix build model * updated quickstart to class model * Updates to quickstart main page, build model page based on feedback (#31) * updates to load class model, build model page work * more work on build model * small formatting fix on build model page (#32) * fix formating on build model page * build model formatting fixes (#33) * build model format fix * Update build_model_tutorial.py * Update build_model_tutorial.py * Update optimization_tutorial.py fixed footer * Update data_quickstart_tutorial.py fix image on data * Update data_quickstart_tutorial.py (#34) Addressed open comments * Update data_quickstart_tutorial.py (#35) Fixed links and formatting * Update data_quickstart_tutorial.py removed github markup * Update data_quickstart_tutorial.py * Update build_model_tutorial.py * Update data_quickstart_tutorial.py (#36) * build model section updates, breadcrumb test, linear wording fix (#37) * removed full top ex, moved sequential to layer ex * fixed linear layer wording * breadcrumb test * move TOC (#39) * removed full top ex, moved sequential to layer ex * fixed linear layer wording * breadcrumb test * rename for auto breadcrumb for tutorials * move table of contents to top * toc fix probably (#40) * how to use this guide text (#41) * removed code blocks moved toc (#42) * Make misc improvements to quickstart (#43) * Refactor buildmodel_tutorial.py to exclude sequential net definition (#44) * moved quickstart home folder, added breadcrumb * add callout quickstart on tutorials page, cap fix * checkin by Cassie: how to run code, fixed typo * checked in by cassie: quickstart updates typo fix * Refactor optimization tutorial * Formatting fixes to optimization tutorial * quickstart home page updates * tensor page edits * cassie checkin: data page review * Update save-load-run quickstart tutorial * checkin by cassie: review/fix transforms page * checkin by cassie: Fixed build model page * checkin by cassie: optimization page, add setup * autograd and optimzation page updates * checkin by cassie: save run load page review * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/autograd_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/autograd_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * checkin by cassie: fix spacing * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * fix link * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * fix link * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * cassie checkin: add next prev links * fix links * fix links * toc tree test * cassie checkin: removed old next prev * Fix missing variable in saveloadrun_tutorial * Update beginner_source/quickstart/quickstart_tutorial.py * "DataSet" -> "Dataset" * Apply suggestions from code review -- buildmodel * add links to author names * formatting * add suraj as author * add loading dataset to data quickstart * init fucntion wording update on datasets * added iterate to datasets section * update quickstart title to 'learn the basics' * refactor - till custom datasets * Updated data * updated buildmodel * update the other sections * final edits Co-authored-by: Jinlin Zhang <jinlinzhang@fb.com> Co-authored-by: v-jizhang <66389669+buck-bot@users.noreply.github.com> Co-authored-by: Pritam Damania <9958665+pritamdamania87@users.noreply.github.com> Co-authored-by: pritam <pritam.damania@fb.com> Co-authored-by: supriyar <supriyar@fb.com> Co-authored-by: Basil Hosmer <bhosmer@fb.com> Co-authored-by: Jeff Tang <jeff.x.tang@gmail.com> Co-authored-by: Brian Johnson <brianjo@fb.com> Co-authored-by: Yuxin Wu <ppwwyyxxc@gmail.com> Co-authored-by: sethjuarez <me@sethjuarez.com> Co-authored-by: Cassie <46505951+cassieview@users.noreply.github.com> Co-authored-by: PythicCoder <aribornstein@gmail.com> Co-authored-by: Dmitri Soshnikov <dmitri@soshnikov.com> Co-authored-by: Cassie Breviu <cassieb@Microsoft.com>
cassiebreviu
added a commit
to sethjuarez/tutorials
that referenced
this pull request
Feb 5, 2021
* refactor - till custom datasets * Updated data * updated buildmodel * update the other sections * final edits * A fix for one line comment when removing runnable code. (pytorch#1165) Co-authored-by: v-jizhang <66389669+buck-bot@users.noreply.github.com> * Update tutorials to use TensorPipeRpcBackendOptions. (pytorch#1164) * Update tutorials to use TensorPipeRpcBackendOptions. * Commit Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Commit2 Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Co-authored-by: pritam <pritam.damania@fb.com> * Update dynamic quant tutorial for saving quantized model (pytorch#1167) Summary: Addresses pytorch/pytorch#43016 Test Plan: Reviewers: Subscribers: Tasks: Tags: * retitle dispatcher tutorial (pytorch#1168) * minor typo fixes (pytorch#1160) Co-authored-by: Brian Johnson <brianjo@fb.com> * Update saving_loading_models.py (pytorch#1173) * Removes Outdated Trainer Tutorial (pytorch#1181) * Update index.rst * Delete aws_distributed_training_tutorial.py * complete PyTorch quickstart proposal * Formatting and wording updates (#27) * corrected rebase errors * Some updates based on feedback to quickstart and build model (#29) * Added more detail to the intro of the quickstart * primitive dataset text update * fix build model * updated quickstart to class model (#30) * fix build model * updated quickstart to class model * Updates to quickstart main page, build model page based on feedback (#31) * updates to load class model, build model page work * more work on build model * small formatting fix on build model page (#32) * fix formating on build model page * build model formatting fixes (#33) * build model format fix * Update build_model_tutorial.py * Update build_model_tutorial.py * Update optimization_tutorial.py fixed footer * Update data_quickstart_tutorial.py fix image on data * Update data_quickstart_tutorial.py (#34) Addressed open comments * Update data_quickstart_tutorial.py (#35) Fixed links and formatting * Update data_quickstart_tutorial.py removed github markup * Update data_quickstart_tutorial.py * Update build_model_tutorial.py * Update data_quickstart_tutorial.py (#36) * build model section updates, breadcrumb test, linear wording fix (#37) * removed full top ex, moved sequential to layer ex * fixed linear layer wording * breadcrumb test * move TOC (#39) * removed full top ex, moved sequential to layer ex * fixed linear layer wording * breadcrumb test * rename for auto breadcrumb for tutorials * move table of contents to top * toc fix probably (#40) * how to use this guide text (#41) * removed code blocks moved toc (#42) * Make misc improvements to quickstart (#43) * Refactor buildmodel_tutorial.py to exclude sequential net definition (#44) * moved quickstart home folder, added breadcrumb * add callout quickstart on tutorials page, cap fix * checkin by Cassie: how to run code, fixed typo * checked in by cassie: quickstart updates typo fix * Refactor optimization tutorial * Formatting fixes to optimization tutorial * quickstart home page updates * tensor page edits * cassie checkin: data page review * Update save-load-run quickstart tutorial * checkin by cassie: review/fix transforms page * checkin by cassie: Fixed build model page * checkin by cassie: optimization page, add setup * autograd and optimzation page updates * checkin by cassie: save run load page review * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/autograd_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/autograd_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * checkin by cassie: fix spacing * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * fix link * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * fix link * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <5676233+suraj813@users.noreply.github.com> * cassie checkin: add next prev links * fix links * fix links * toc tree test * cassie checkin: removed old next prev * Fix missing variable in saveloadrun_tutorial * Update beginner_source/quickstart/quickstart_tutorial.py * "DataSet" -> "Dataset" * Apply suggestions from code review -- buildmodel * add links to author names * formatting * add suraj as author * add loading dataset to data quickstart * init fucntion wording update on datasets * added iterate to datasets section * update quickstart title to 'learn the basics' * refactor - till custom datasets * Updated data * updated buildmodel * update the other sections * final edits * update index.rst * delete devcontainer and gh workflows * restore index.rst - update with separate PR Co-authored-by: Jinlin Zhang <jinlinzhang@fb.com> Co-authored-by: v-jizhang <66389669+buck-bot@users.noreply.github.com> Co-authored-by: Pritam Damania <9958665+pritamdamania87@users.noreply.github.com> Co-authored-by: pritam <pritam.damania@fb.com> Co-authored-by: supriyar <supriyar@fb.com> Co-authored-by: Basil Hosmer <bhosmer@fb.com> Co-authored-by: Jeff Tang <jeff.x.tang@gmail.com> Co-authored-by: Brian Johnson <brianjo@fb.com> Co-authored-by: Yuxin Wu <ppwwyyxxc@gmail.com> Co-authored-by: sethjuarez <me@sethjuarez.com> Co-authored-by: Cassie <46505951+cassieview@users.noreply.github.com> Co-authored-by: PythicCoder <aribornstein@gmail.com> Co-authored-by: Dmitri Soshnikov <dmitri@soshnikov.com> Co-authored-by: Cassie Breviu <cassieb@Microsoft.com>
rodrigo-techera
pushed a commit
to Experience-Monks/tutorials
that referenced
this pull request
Nov 29, 2021
* Update tutorials to use TensorPipeRpcBackendOptions. * Commit Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Commit2 Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Co-authored-by: pritam <pritam.damania@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.