Skip to content

Disable memory_format_tutorial on Windows CI #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

guyang3532
Copy link
Contributor

@guyang3532 guyang3532 commented Aug 5, 2020

To resolve #1101

memory_format_tutorial.py uses setattr() to modify the attributes of torch. This will cause CI test failure to other tutorials because they are all executed in one process in sphinx.
This bugs will not influence the linux because tutorials are running parallelly with 20 workers on CircleCI for linux and memory_format_tutorial and other related tutorials are running in different workers.
This pr fix it by disable memory_format_tutorial.py when running windows CI test.

test at #1106

@netlify
Copy link

netlify bot commented Aug 5, 2020

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 8d61c2f

https://deploy-preview-1105--pytorch-tutorials-preview.netlify.app

@netlify
Copy link

netlify bot commented Aug 5, 2020

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 2f5d251

https://deploy-preview-1105--pytorch-tutorials-preview.netlify.app

@guyang3532
Copy link
Contributor Author

@brianjo @seemethere
This will fix the windows CircleCI test failures.
Test passed at #1106

@guyang3532 guyang3532 changed the title Fix errors caused by memory_format_tutorial Disable memory_format_tutorial on Windows CI Aug 5, 2020
@seemethere seemethere merged commit eb01560 into pytorch:master Aug 5, 2020
@brianjo
Copy link
Contributor

brianjo commented Aug 6, 2020

@guyang3532 @seemethere The win_test_worker is going on 3 hours. Could you take a look? I don't think you need to revert, but if you could tweak whatever this is doing with a new PR we can start this build fresh. (Or I can restart that thread.) Thanks https://app.circleci.com/pipelines/github/pytorch/tutorials?branch=master

rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numeric_suite_tutorial and graph_mode_static_quantization_tutorial fail on CI test
3 participants