Skip to content

fix bugs for data_loading_tutorial and dcgan_faces_tutorial #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

guyang3532
Copy link
Contributor

@guyang3532 guyang3532 commented Jul 29, 2020

bug in data_loading_tutorial:
This tutorial fails on windows because code with multiple processes must be put in main() function on windows platform. And to not change the structure of the tutorial html page, just modify the multiple processes to single process.

bug in dcgan_faces_tutorial:
When pytorch updating from v1.5 to v1.6, one warning message "Providing a bool or integral fill value without setting the optional dtype or out arguments is currently unsupported." is changed to error. So change the tutorial correspondingly.

@netlify
Copy link

netlify bot commented Jul 29, 2020

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 1131753

https://deploy-preview-1092--pytorch-tutorials-preview.netlify.app

@guyang3532 guyang3532 force-pushed the fix_bugs branch 2 times, most recently from 5218d30 to e39a3f9 Compare July 31, 2020 03:28
@guyang3532
Copy link
Contributor Author

The error seems not related.

@guyang3532 guyang3532 force-pushed the fix_bugs branch 3 times, most recently from 328d3e9 to d62f788 Compare August 5, 2020 15:26
@guyang3532
Copy link
Contributor Author

@seemethere

@seemethere seemethere merged commit fdbe99c into pytorch:master Aug 19, 2020
brianjo added a commit that referenced this pull request Sep 24, 2020
* Fix typo (#1118)

In PyTorch tutorial, `torch` should be installed rather than `torchaudio`

* Recover the attributes of torch in memory_format_tutorial (#1112)

Co-authored-by: Brian Johnson <brianjo@fb.com>

* fix bugs for data_loading_tutorial and dcgan_faces_tutorial (#1092)

* Update autocast in dispatcher tutorial (#1128)

* draft

* fixes

* dont overrun the line

* Corrected model.resnet50() spelling (#1139)

Spelling mistake led to errors for beginners.

* Fix typo & Minor changes (#1138)

Thanks for the fixes @codingbowoo!

* Run win_test_worker manually (#1142)

Merging to clean up a build issue.

* Disable `pytorch_windows_builder_worker` config (#1143)

See #1141

* Update index.rst (#1140)

Fixed incorrect link.

* Update index.rst

Fix to broken link.

* LSTM's -> LSTMs in equence_models_tutorial.py docs (#1136)

Co-authored-by: Brian Johnson <brianjo@fb.com>

* Added Ray Tune Hyperparameter Tuning Tutorial (#1066)

* Added Ray Tune Hyperparameter Tuning Tutorial

* Use nightly ray release

* Fix checkpoint API

Co-authored-by: Brian Johnson <brianjo@fb.com>

* Fix typo in "Introduction to Pytorch" tutorial (in NLP tutorial) (#1145)

* Fix typo in "Introduction to Pytorch" tutorial (in Pytorch for NLP tutorials)

* Dummy commit, to restart CI

* Revert dummy commit, to restart CI

* Revert whitespace changes

* Install torch not torch vision (#1153)

Small update to recipe that instructs users to install `torch` not `torchaudio`

* Python recipe for automatic mixed precision (#1137)

* fdsa

* Tutorial runs

* clarify one scaler per convergence run

* adjust sizes, dont run illustrative sections

* satisfying ocd

* MORE

* fdsa

* details

* rephrase

* fix formatting

* move script to recipes

* hopefully moved to recipes

* fdsa

* add amp_tutorial to toctree

* amp_tutorial -> amp_recipe

* looks like backtick highlights dont render in card_description

* correct path for amp_recipe.html

* arch notes and saving/restoring

* formatting

* fdsa

* Clarify autograd-autocast interaction for custom ops

* touchups

Co-authored-by: Brian Johnson <brianjo@fb.com>

* Fix model to be properly exported to ONNX (#1144)

Co-authored-by: Brian Johnson <brianjo@fb.com>

* Dist rpc merge (#1158)

* Create distributed_rpc_profiling.rst

* Update recipes_index.rst

* Add files via upload

* Update recipes_index.rst

* Fix typo "asynchronizely" -> "asynchronously" (#1154)

* Update dist_overview with additional information. (#1155)

Summary: 1) Added DDP + RPC tutorial.
2) Added a pointer to PT Distributed CONTRIBUTING.md.

Test Plan: Verified by loading the page locally.

Reviewers: sentinel

Subscribers:

Tasks:

Tags:

Co-authored-by: pritam <pritam.damania@fb.com>

* Add Performance Tuning guide recipe (#1161)

* Performance Tuning Guide - initial commit

* Minor tweaks

* Switched profiling guide thumbnail to pytorch logo

* Converted Tuning Guide to 80 chars/line

* Split tuning guide into general, GPU-specific and distributed optimizations.

* WAR to fix generation of header for 1st section

* Minor fixes

* Implemented changes suggested during initial review

* Changed 'addition assignment' to 'addition'

* Removed sentences about 1 CPU core for DataParallel training

* Reordering of layers is recommended only for DDP(find_unused_parameters=True)

* Fixed formatting

* s/constructors/model constructors and s/match/roughly match

* Fixed typos

* A fix for one line comment when removing runnable code. (#1165)

Co-authored-by: v-jizhang <66389669+buck-bot@users.noreply.github.com>

Co-authored-by: Nikita Shulga <nshulga@fb.com>
Co-authored-by: guyang3532 <62738430+guyang3532@users.noreply.github.com>
Co-authored-by: mcarilli <mcarilli@gmail.com>
Co-authored-by: Sayantan Das <36279638+ucalyptus@users.noreply.github.com>
Co-authored-by: 장보우 Bowoo Jang <lisabowoo@gmail.com>
Co-authored-by: Alan deLevie <adelevie@gmail.com>
Co-authored-by: krfricke <krfricke@users.noreply.github.com>
Co-authored-by: Vijay Viswanathan <vcomeinpeace@gmail.com>
Co-authored-by: J. Randall Hunt <randallhunt@gmail.com>
Co-authored-by: Thiago Crepaldi <thiago.crepaldi@microsoft.com>
Co-authored-by: Peter Whidden <all.cows.like.to.moo@gmail.com>
Co-authored-by: Pritam Damania <9958665+pritamdamania87@users.noreply.github.com>
Co-authored-by: pritam <pritam.damania@fb.com>
Co-authored-by: Szymon Migacz <1934379+szmigacz@users.noreply.github.com>
Co-authored-by: Jinlin Zhang <jinlinzhang@fb.com>
Co-authored-by: v-jizhang <66389669+buck-bot@users.noreply.github.com>
rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants