Skip to content

Update ptcheat.rst #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 28, 2021
Merged

Update ptcheat.rst #1083

merged 6 commits into from
Sep 28, 2021

Conversation

edwardleardi
Copy link
Contributor

scheduler.step() should not be called at the start of every epoch as of PyTorch 1.1.0. Instead it should be called after the optimizer has updated the weights (after optimizer.step() is called)

@edwardleardi
Update ptcheat.rst
6d284d2 
scheduler.step() should not be called at the start of every epoch as of PyTorch 1.1.0. Instead it should be called after the optimizer has updated the weights (after optimizer.step() is called)
@netlify
Copy link

netlify bot commented Jul 24, 2020 •
edited
Loading

✔️ Deploy Preview for pytorch-tutorials-preview ready!

🔨 Explore the source changes: 188533c

🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/61531d4732776b000724217d

😎 Browse the preview: https://deploy-preview-1083--pytorch-tutorials-preview.netlify.app/beginner/ptcheat

Base automatically changed from master to main February 16, 2021 19:33
Base automatically changed from main to master February 16, 2021 19:37
@facebook-github-bot
Copy link
Contributor

Hi @edwardleardi!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@holly1238
Copy link
Contributor

Hi @edwardleardi! Can you sign the CLA agreement so that I can merge the pull request? Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@holly1238 holly1238 merged commit 533531f into pytorch:master Sep 28, 2021
rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
@edwardleardi @brianjo @holly1238
Update ptcheat.rst (pytorch#1083)
b704eba 
scheduler.step() should not be called at the start of every epoch as of PyTorch 1.1.0. Instead it should be called after the optimizer has updated the weights (after optimizer.step() is called)

Co-authored-by: Brian Johnson <brianjo@fb.com>
Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edwardleardi @facebook-github-bot @holly1238 @brianjo