Skip to content

Apply PEP 8 formatting to transformer_tutorial.py imports #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2021

Conversation

jgerityneurala
Copy link
Contributor

This PR brings all imports to the top of the surrounding code, according to PEP 8.

The change that brought me here was

class TransformerModel(nn.Module):
    def __init__(self, ntoken, ninp, nhead, nhid, nlayers, dropout=0.5):
        super(TransformerModel, self).__init__()
        from torch.nn import TransformerEncoder, TransformerEncoderLayer
        # ...

An import inside of __init__() like this is extremely uncommon, and it does not look like it's necessary to have it here in this case. If there is a reason the change shouldn't be made, there should explanatory text of why it is an exception to "imports are always at the top of the file" as PEP 8 has it. I know this project isn't explicitly PEP 8, but this doesn't vary too much across style conventions IME.

@netlify
Copy link

netlify bot commented Jun 5, 2020

Deploy preview for pytorch-tutorials-preview ready!

Built with commit be23f3f

https://deploy-preview-1014--pytorch-tutorials-preview.netlify.app

Base automatically changed from master to main February 16, 2021 19:33
Base automatically changed from main to master February 16, 2021 19:37
@facebook-github-bot
Copy link
Contributor

Hi @jgerityneurala!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@holly1238
Copy link
Contributor

Hi @jgerityneurala! Can you sign the CLA agreement so that I can merge the pull request? Thanks!

@jgerityneurala
Copy link
Contributor Author

Hi @jgerityneurala! Can you sign the CLA agreement so that I can merge the pull request? Thanks!

Whoops, I didn't realize there was one when I submitted this PR. Just signed it, thanks.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@jgerityneurala
Copy link
Contributor Author

CI failure is due to exceeding the timeout, shouldn't be caused by this PR's content

@holly1238 holly1238 merged commit 3e6d1f4 into pytorch:master Apr 23, 2021
rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants