Description
Hello, I am translating PyTorch Tutorials in Korean.
(I have been translating drafts of the 0.4 and the 0.3.1 with some contributers.)
After 1.0 has been released recently, I have been taking a 1.0 tutorial.
In the meantime, I noticed some improvements to make download as follows:
-
Using
wget
andcurl
are mixed.
=> Suggestion: What if we unify as one? I suggestwget
already using the-N
(timestamping) option. Some data likeUrbanSound8K
have a very large data size(over 5GB), and it seems like it will take a very long time to build each time. -
The download location is not specified properly.
=> Suggestion: How about creating a temporary directory (eg_data
) usingwget
's-P
option? Could be using a variable like$DATADIR
inMakefile
. Also, I think this will make managing.gitignore
easier. -
How about using templates for downloading / unpacking data files?
=> Suggestion: I saw> null
, but in fact, everything is created in a file namednull
because it is not/dev/null
. I'm not sure I needsudo
orchmod
to download the data. Would not it be enough to just (1) download the file and / (2) (if necessary) extract / (3) move or delete downloaded file?
Please review and comment. If others agree, I'll modify the Makefile
.
Thanks.