Ensure correct encoding for non-contiguous WF #666
Conversation
facebook-github-bot
added
the
CLA Signed
| TORCH_CHECK(wf.dim() == 2, "waveform must have 2 dimensions, got ", wf.dim()); | ||
| return wf; | ||
| return wf.contiguous(); |
There was a problem hiding this comment.
Confirming that this is load-bearing: newly added test fails if we just return wf without calling contiguous().
| @@ -1284,6 +1284,35 @@ def test_encode_to_tensor_long_output(self): | |||
|
|
|||
| torch.testing.assert_close(self.decode(encoded_tensor), samples) | |||
|
|
|||
| def test_contiguity(self): | |||
There was a problem hiding this comment.
Can you provide some narration in the test about what exactly we're testing? I'm afraid I'm not familiar enough with tensor manipulation to fully understand everything. For example, I'm surprised assert_close(contiguous_samples, non_contiguous_samples) passes when they have different strides.
There was a problem hiding this comment.
Done.
The strides have to do with the representation of the tensor in memory. But it's not what uniquely determines the values of a tensor. E.g. a 2D tensor
A B
C D
can be represented in memory as
A B C D
or as
A C B D
They'd have different strides, but equal values.
TSIA!