Add bit_rate parameter to encoder #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
commented
Apr 7, 2025
| // best-effort, matching to the closest supported bit_rate. I.e. passing 1 is | ||
| // like passing 0, which results in choosing the minimum supported bit rate. | ||
| // Passing 44_100 could result in output being 44000 if only 44000 is | ||
| // supported. |
There was a problem hiding this comment.
Note: I don't think there is a way to list the supported bit rates of the encoder. It's possible for sample rates, but not for bit rates.
NicolasHug
commented
Apr 7, 2025
| # TODO-ENCODING: tol should be stricter. We need to increase the encoded | ||
| # bitrate, and / or encode into a lossless format. | ||
| # TODO-ENCODING: tol should be stricter. We probably need to encode | ||
| # into a lossless format. |
There was a problem hiding this comment.
I tried to pass bit_rate=40_000 and was able to decrease tolerance from 0.07 to 0.05, but that's clearly not strict enough still.
scotts
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.