Skip to content

[validations] Fix stable cuda validation for pypi release. Cleanup unused code. #6558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Apr 23, 2025

  1. Fixed an issue in tools/scripts/generate_binary_build_matrix.py hardcoded 12.4 value. Use STABLE_CUDA_VERSIONS instead
  2. remove special cases validate pypi. Since pypi should be validated using default workflow.
  3. Fixed poetry validations

Copy link

vercel bot commented Apr 23, 2025

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2025
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, though poetry testing might not be a fully functional, but it's better to have some testing rather than nothing

@atalman
Copy link
Contributor Author

atalman commented Apr 23, 2025

Sounds good @malfet let me fix the poetry test. We should try to execute it on the nightly and test channels before release. Maybe as an option

@atalman atalman merged commit 1e628ca into pytorch:main Apr 24, 2025
54 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants