[TorchFix] Add torch.solve as a removed function #4705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
kit1980
force-pushed
the
sdym/torchfix-solve
branch
from
c0ed87d to
a25c3b1
Compare
facebook-github-bot
added
the
CLA Signed
kit1980
force-pushed
the
sdym/torchfix-solve
branch
from
a25c3b1 to
83da406
Compare
kit1980
force-pushed
the
sdym/torchfix-solve
branch
from
83da406 to
342314e
Compare
kit1980
force-pushed
the
sdym/torchfix-solve
branch
from
342314e to
5c1d68b
Compare
clee2000
approved these changes
Nov 9, 2023
ZainRizvi
approved these changes
Nov 9, 2023
|
|
||
| ### TOR001 Use of removed function | ||
|
|
||
| #### torch.solve |
There was a problem hiding this comment.
Is there a doc/page that calls out this function as deprecated? If so, what do you think of linking to it here?
There was a problem hiding this comment.
No, it's removed from the docs.
The YAML in the PR has links to deprecate and remove PRs, I plan later to use these links to generate some docs.
|
|
||
| This function was deprecated since PyTorch version 1.9 and is now removed. | ||
|
|
||
| `torch.solve` is deprecated in favor of `torch.linalg.solve`. |
There was a problem hiding this comment.
Seems like we still mention torch.solve in our docs. Could you update that ref too please?
There was a problem hiding this comment.
Good find! I'll update that.
There was a problem hiding this comment.
malfet
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add torch.solve as a removed function (I somehow missed it before and noticed after pytorch/tutorials#2642).
Also added a mechanism to show reference links in the error messages.