Skip to content

generate 1.10.1 docs and make them 'stable' #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2021
Merged

generate 1.10.1 docs and make them 'stable' #899

merged 2 commits into from
Dec 20, 2021

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Dec 17, 2021

@brianjo

Fixes #898

I installed pytorch 1.10.1, and in the docs directory of pytorch did export RELEASE=1; make html. I then copied the resulting documentation into a 1.10.1 directory here, added it to the version.html, and reset stable to point to 1.10.1.

@netlify
Copy link

netlify bot commented Dec 17, 2021

👷 Deploy Preview for pytorch-dot-org-preview processing.

🔨 Explore the source changes: 763c476

🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-dot-org-preview/deploys/61c0b0779050460007cfa8b9

@brianjo
Copy link
Contributor

brianjo commented Dec 17, 2021

Thank you so much Matti! Looks good. I'll merge this after it passes tests.

@brianjo
Copy link
Contributor

brianjo commented Dec 17, 2021

I think we might be missing the Google Analytics block in the generated pages.

  <!-- Google Analytics -->
  
    <script async src="https://www.googletagmanager.com/gtag/js?id=UA-117752657-2"></script>
    <script>
      window.dataLayer = window.dataLayer || [];
      function gtag(){dataLayer.push(arguments);}
      gtag('js', new Date());

      gtag('config', 'UA-117752657-2');
    </script>
  
  <!-- End Google Analytics -->

@mattip
Copy link
Contributor Author

mattip commented Dec 20, 2021

I think we might be missing the Google Analytics block in the generated pages.

fixed now.

@brianjo
Copy link
Contributor

brianjo commented Dec 20, 2021

I think we might be missing the Google Analytics block in the generated pages.

fixed now.

Awesome. Thanks Matti!

@brianjo brianjo merged commit 4b4761f into pytorch:site Dec 20, 2021
facebook-github-bot pushed a commit to pytorch/pytorch that referenced this pull request Jan 5, 2022
Summary:
Fixes #70185

The extraheader block in docs/source/_templates/layout.html overrides the one from the pytorch theme. The theme block adds Google Analytics, so they were missing from the `master` documentation. This came up in PR pytorch/pytorch.github.io#899.

brianjo

Pull Request resolved: #70187

Reviewed By: bdhirsh

Differential Revision: D33248466

Pulled By: malfet

fbshipit-source-id: b314916a3f0789b6617cf9ba6bd938bf5ca27242
wconstab pushed a commit to pytorch/pytorch that referenced this pull request Jan 5, 2022
Summary:
Fixes #70185

The extraheader block in docs/source/_templates/layout.html overrides the one from the pytorch theme. The theme block adds Google Analytics, so they were missing from the `master` documentation. This came up in PR pytorch/pytorch.github.io#899.

brianjo

Pull Request resolved: #70187

Reviewed By: bdhirsh

Differential Revision: D33248466

Pulled By: malfet

fbshipit-source-id: b314916a3f0789b6617cf9ba6bd938bf5ca27242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.10.1 was released, but the documentation at https://pytorch.org/docs/stable says 1.10.0
3 participants