Skip to content

Add links to CUDA-11 nightly packages #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Oct 8, 2020

No description provided.

@netlify
Copy link

netlify bot commented Oct 8, 2020

Deploy preview for pytorch-dot-org-preview processing.

Building with commit bb6b54f

https://app.netlify.com/sites/pytorch-dot-org-preview/deploys/5f7ea9e93298ec00076aaf78

@soumith
Copy link
Member

soumith commented Oct 8, 2020

do you want to merge this after the 1.7 release or do you want to merge now?

if you want to merge now, the stable entries are also filled for cuda11 and presumably the stable build doesn't have a cuda11 version

@jspisak
Copy link
Contributor

jspisak commented Oct 8, 2020

Are we getting rid of the 'None' option here? Or else we need to add another button to the selector.

@malfet
Copy link
Contributor Author

malfet commented Oct 8, 2020

Thank you for the feedback, will add another column to selector

@soumith
Copy link
Member

soumith commented Oct 8, 2020

the None option is still there, the css needs to be adjusted that's all.

@soumith
Copy link
Member

soumith commented Oct 8, 2020

currently, the divs are tagged as col-md-3, so they cant display this many options but you can play with that variable: https://www.w3schools.com/bootstrap/bootstrap_grid_examples.asp

for example col-md-5 or something might work

12 doesn't divide by 5 evenly
@seemethere
Copy link
Member

Something doesn't look right on the preview deploy, looks like we're getting CUDA 11.0 in the "Stable" category

@malfet
Copy link
Contributor Author

malfet commented Oct 8, 2020

I have following 3 variants:
Using col-md(5 columns of the same width):
col-md
Using col-md-2 for first 3 columns and col-md-3 for remaining 2 (imo, creates unnecessary focus on None and CUDA-11 options but have a nice center line)
col-md-2-2-2-3-3
Using col-md-3 for latest versions of major CUDA release and col-md-2 for 10.1 and None:
col-md-3-2-3-2-2

@jspisak
Copy link
Contributor

jspisak commented Oct 8, 2020

thanks for wireframing this up! I like the first one.. :)

@malfet
Copy link
Contributor Author

malfet commented Oct 8, 2020

@soumith I can do it now or later, as stable links should redirect to build from source instructions

@soumith
Copy link
Member

soumith commented Oct 10, 2020

as stable links should redirect to build from source instructions

If you want to merge now, which I am fine with, then have the stable configs explicitly say "CUDA 11 is not yet supported with PyTorch 1.6. Either try the nightlies or wait for PyTorch 1.7"

@malfet malfet merged commit e69fa62 into site Oct 27, 2020
@malfet malfet deleted the malfet/add-links-to-cuda11-nightly-binaries branch September 6, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants