Skip to content

Replace mobile with executorch on the getting started page #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

clee2000
Copy link

@clee2000 clee2000 commented Apr 29, 2024

Not entirely sure what I'm doing, the preview works?

Redirects immediately to the executorch page

@clee2000 clee2000 marked this pull request as draft April 29, 2024 22:34
Copy link

netlify bot commented Apr 29, 2024

👷 Deploy Preview for pytorch-dot-org-preview processing.

Name Link
🔨 Latest commit 1957301
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-dot-org-preview/deploys/663029772a85ca0008ad35ab

@clee2000 clee2000 marked this pull request as ready for review April 29, 2024 23:06
Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Looking towards @ali-khosh for a second look as well

@ali-khosh
Copy link

Please use "ExecuTorch" vs. "Executorch" when referring to the project for consistency.

In this particular instance please replace Executorch with Edge and point it to https://pytorch.org/edge to make it consistent with the headers on other pages.

@malfet
Copy link
Contributor

malfet commented Apr 29, 2024

Before we land this, is there a sign off(in form of a review for example) from someone that we are removing the mobile section?

@clee2000
Copy link
Author

clee2000 commented Apr 29, 2024

Please use "ExecuTorch" vs. "Executorch" when referring to the project for consistency.

Fixed on most recent commit

In this particular instance please replace Executorch with Edge and point it to https://pytorch.org/edge to make it consistent with the headers on other pages.

https://docs.google.com/document/d/1slnDApwhccfKI2qf75eOtA4ilyMCGF1tM36GxMBOR4U/edit#heading=h.xys1j0me4mye says to replace mobile with executorch, do you want to replace mobile with edge instead? Is there some other reference to mobile that I'm not seeing?

@seemethere
Copy link
Member

Before we land this, is there a sign off(in form of a review for example) from someone that we are removing the mobile section?

I'm guessing @ali-khosh would be the authority here

@ali-khosh
Copy link

@seemethere yes please go ahead. OK to remove the PT Mobile link 

@clee2000
Copy link
Author

Closing this because it already happened in #1615

@clee2000 clee2000 closed this Apr 30, 2024
@cjyabraham cjyabraham deleted the csl/get_started_executorch branch August 2, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants