-
Notifications
You must be signed in to change notification settings - Fork 306
Replace mobile with executorch on the getting started page #1614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy Preview for pytorch-dot-org-preview processing.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Looking towards @ali-khosh for a second look as well
Please use "ExecuTorch" vs. "Executorch" when referring to the project for consistency. In this particular instance please replace Executorch with Edge and point it to https://pytorch.org/edge to make it consistent with the headers on other pages. |
Before we land this, is there a sign off(in form of a review for example) from someone that we are removing the mobile section? |
Fixed on most recent commit
https://docs.google.com/document/d/1slnDApwhccfKI2qf75eOtA4ilyMCGF1tM36GxMBOR4U/edit#heading=h.xys1j0me4mye says to replace mobile with executorch, do you want to replace mobile with edge instead? Is there some other reference to mobile that I'm not seeing? |
I'm guessing @ali-khosh would be the authority here |
@seemethere yes please go ahead. OK to remove the PT Mobile link |
Closing this because it already happened in #1615 |
Not entirely sure what I'm doing, the preview works?
Redirects immediately to the executorch page