Mnist update #469
Merged
Mnist update #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumith
requested changes
Dec 13, 2018
mnist/main.py
Outdated
| x = self.fc2(x) | ||
| return F.log_softmax(x, dim=1) | ||
|
|
||
|
|
||
| def name(self): |
There was a problem hiding this comment.
this function should be removed
mnist/main.py
Outdated
| if (args.save_model): | ||
| PATH="mnist_cnn.pt" | ||
| torch.save(model.state_dict(), PATH) | ||
| print("model saved as mnist_cnn.pt in the current working directory\n") |
mnist/main.py
Outdated
| train(args, model, device, train_loader, optimizer, epoch) | ||
| test(args, model, device, test_loader) | ||
|
|
||
| if (args.save_model): | ||
| PATH="mnist_cnn.pt" |
There was a problem hiding this comment.
additional PATH is unncessary, do torch.save(model.state_dict(), "mnist_cnn.pt")
mnist/main.py
Outdated
| @@ -100,10 +107,14 @@ def main(): | |||
| model = Net().to(device) | |||
| optimizer = optim.SGD(model.parameters(), lr=args.lr, momentum=args.momentum) | |||
|
|
|||
| for epoch in range(1, args.epochs + 1): | |||
| for epoch in range(1, args.epochs+1): | |||
There was a problem hiding this comment.
args.epochs + 1 is cleaner. Revert this change
|
@soumith i have made the changes as asked by you. |
soumith
approved these changes
Dec 13, 2018
|
thank you @surgan12 ! |
|
@soumith my pleasure always ! |
YinZhengxun
pushed a commit
to YinZhengxun/mt-exercise-02
that referenced
this pull request
Mar 30, 2025
* mnist added dcgan * mnist added * mnist improved * Update main.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the architecture of the Mnist , simplifying it and increasing the accuracy.
Also added the functionalty of saving the model as an argument.