Skip to content

[Tensor Parallel] update examples to simplify embedding + first transformer block #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2024

Conversation

tianyu-l
Copy link
Contributor

@tianyu-l tianyu-l commented May 16, 2024

Stack from ghstack (oldest at bottom):

Following changes in pytorch/torchtitan#314, to apply a reduce-scatter instead of the more expensive all-reduce + local chunk.

cross PR with pytorch/tutorials#2871

…first transformer block"


Following changes in pytorch/torchtitan#314, to apply a reduce-scatter instead of the more expensive all-reduce + local chunk.

cross PR with pytorch/tutorials#2871

[ghstack-poisoned]
tianyu-l added a commit that referenced this pull request May 16, 2024
…former block

ghstack-source-id: 4396c58
Pull Request resolved: #1259
tianyu-l added a commit to pytorch/tutorials that referenced this pull request May 16, 2024
…first transformer block"


cross PR with pytorch/examples#1259


[ghstack-poisoned]
Copy link
Contributor

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tianyu-l tianyu-l merged commit 0960b2e into gh/tianyu-l/1/base May 16, 2024
1 check passed
tianyu-l added a commit that referenced this pull request May 16, 2024
…former block

ghstack-source-id: 4396c58
Pull Request resolved: #1259
@tianyu-l tianyu-l deleted the gh/tianyu-l/1/head branch May 16, 2024 17:40
YinZhengxun pushed a commit to YinZhengxun/mt-exercise-02 that referenced this pull request Mar 30, 2025
…former block

ghstack-source-id: 4396c58
Pull Request resolved: pytorch#1259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants