Conformance: Make "# E[tag]" exactly once, add support for at least once #1982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
commented
Apr 22, 2025
| @@ -70,28 +70,28 @@ def not_abstract(self, x: str) -> str: ... | |||
| class C: | |||
| @overload # E[func5] | |||
| @staticmethod | |||
| def func5(x: int) -> int: # E[func5] | |||
| def func5(x: int, /) -> int: # E[func5] | |||
There was a problem hiding this comment.
I tried to get rid of various unrelated errors detected by some type checkers so that this test case focuses on only the issue it's trying to test for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #1981 (comment).
The documentation said
# E[tag]meant the error must appear on exactly one of the tagged lines, but the implementation enforced at least one error instead. I think "exactly one" is usually the better choice, so I made it do that. However, in a few cases we do want "at least one". For example, with two mutually recursive type aliases, mypy errors on both and pyright only on the first. Both of those behaviors seem sensible, so I added a new syntax# E[tag+]that means an error must appear on at least one of the tagged lines.Also added a section to the README explaining all the syntax.