download:download_release_detail view: Display file sizes with human-readable units
#2354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the release file sizes more readable by passing them through the [filesizeformat filter][1]. [1]: https://docs.djangoproject.com/en/2.2/ref/templates/builtins/#filesizeformat
Adds a subTest to downloads.tests.test_views.DownloadViewsTests.test_download_release_detail to verify that the file size is displayed in MB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing the download files for a given release, their file sizes are displayed in bytes, which can be 8 digits long, making them difficult to read. To remedy this, the
filesizeformattemplate filter can be used to reduce the number of digits to a more easily read amount.Before
See how the numbers in the File Size column are very large and difficult to compare.
After
Now see how the values in the File Size column can be quickly parsed and compared visually.
Unit test
A small subtest has been added to enforce this display change without affecting the rest of the testing method:
docker-compose run --rm web \ ./manage.py test -k \ downloads.tests.test_views.DownloadViewsTests.test_download_release_detail