Configure github-actions to ensure not have migrations to be created #1839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berinhard
suggested changes
Aug 11, 2021
There was a problem hiding this comment.
@luzfcb I think failing tests because migrations are missing can be something annoying under certain scenarios (configuring blank for admin forms, for example), even though having this check is definitely a nice to have. What do you think about, instead of having these tests, adding a call for python manage.py makemigrations --dry-run --check to our CI file?
In my opinion this sounds better because the contributor will still have a warning about the missing migration without having a direct affect on their development workflow.
luzfcb
changed the title
berinhard
approved these changes
Aug 19, 2021
Merged
luzfcb
changed the title
|
@berinhard I updated pr to use Github Actions instead of Travis-ci |
berinhard
approved these changes
Aug 24, 2021
raghavthind2005
approved these changes
Mar 15, 2022
|
Closed by #2248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request adds
python manage.py makemigrations --dry-run --checkto the github actions configuration to avoid forget to create a migration file when modifying a django model or update a dependency.--
Pull-request sponsored by