Skip to content

fix input-output order in interpreter example #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2021
Merged

fix input-output order in interpreter example #1763

merged 2 commits into from
May 11, 2021

Conversation

sblondon
Copy link
Contributor

The output of input() function should be printed immediately, not merged with the output of print() function:

>>> name = input('What is your name?\n')
What is your name?\nPython
>>> print('Hi, %s.' % name)
Hi, Python.
>>>

Copy link
Contributor

@berinhard berinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch.

@sblondon
Copy link
Contributor Author

sblondon commented May 9, 2021

Thanks @berinhard for the review. Do we need to ping someone else for the merge?

@berinhard
Copy link
Contributor

Maybe a quick review from @ewdurbin or @Mariatta would be nice. Although I've been working on this code base for the last months, I'm not comfortable on merging PRs as the only reviewer.

from wkeithvan and ewdurbin

Co-authored-by: Ee W. Durbin III <ewdurbin@gmail.com>
@ewdurbin
Copy link
Member

Thank you @sblondon

@ewdurbin ewdurbin merged commit b35f56c into python:master May 11, 2021
@sblondon sblondon deleted the order-output-code-example branch May 12, 2021 09:18
@sblondon
Copy link
Contributor Author

sblondon commented Nov 4, 2022

The fixed version is not visible on python.org. I hoped the release of python3.11 would embed it automatically but I was wrong.

Who should I request to push it publicly?

@ewdurbin
Copy link
Member

ewdurbin commented Nov 4, 2022

Didn't see the very bottom of the file where these load data into a model, thought they were generated from the factory code. Update has been applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants