Make Options work under mypyc #5518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires reworking a bunch of operations to not directly depend on the __dict__
ilevkivskyi
approved these changes
Aug 26, 2018
| PROGRAM_TEXT = 2 # type: ClassVar[int] | ||
|
|
||
|
|
||
| PER_MODULE_OPTIONS = { |
There was a problem hiding this comment.
Maybe add a short comment why PER_MODULE_OPTIONS and OPTIONS_AFFECTING_CACHE can't be ClassVars in Options (similar to what you did for fastparse.py IIRC)?
gvanrossum
reviewed
Aug 27, 2018
mypy/options.py
Outdated
| del d['per_module_cache'] | ||
| return d | ||
|
|
||
| def __eq__(self, other: object) -> bool: | ||
| return self.__class__ == other.__class__ and self.__dict__ == other.__dict__ | ||
| return isinstance(other, Options) and self.snapshot() == other.snapshot() |
There was a problem hiding this comment.
This looks like this __eq__ will become much more expensive. Have you tracked where/how it is used?
There was a problem hiding this comment.
I remembered from when I was looking into this while doing the original snapshot stuff that the answer was "not often", but I looked more closely and the answer was: in exactly one test. I just removed __eq__ and made that test use snapshot directly
| @@ -209,12 +214,16 @@ def __init__(self) -> None: | |||
|
|
|||
| def snapshot(self) -> object: | |||
| """Produce a comparable snapshot of this Option""" | |||
| d = dict(self.__dict__) | |||
| # Under mypyc, we don't have a __dict__, so we need to do worse things. | |||
| d = dict(getattr(self, '__dict__', ())) | |||
There was a problem hiding this comment.
So IIUC under mypyc d will start out empty?
gvanrossum
approved these changes
Aug 28, 2018
This reverts commit b336dc8.
JukkaL
added a commit
that referenced
this pull request
Nov 23, 2021
These silence errors about missing type annotations for calls
like these:
```
x = getattr(o, 'a', [])
y = getattr(o, 'b', {})
```
This is basically a generalization of #5518 and other overloads we already
have.
This works around #11572. I encountered the issue in several
places when testing recent typeshed against an internal repo.
Manually cherry-picked from python/typeshed#6355.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires reworking a bunch of operations to not directly depend
on
__dict__