Skip to content

Update steps for 'Getting the source code' and link 'Git Bootcamp' #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 15, 2022

Conversation

abdnafees
Copy link
Contributor

This PR contains the following changes mentioned in issue number #964:

  • list all upstream-related commands in a single step and code block
  • have the same commands in the boot camp, but with more in-depth discussions (e.g. why they are necessary)
  • from here, link to the boot camp so that people that want more details can find them there
  • add a couple of comments about the duplicated commands as a reminder for people updating either page

@ghost
Copy link

ghost commented Nov 15, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

There are two .DS_Store files that got included accidentally and should be removed.
I usually use git add -p while adding changes, in order to both verify exactly what gets added and to review it while I do (and sometimes also to break changes into multiple commits).

@abdnafees
Copy link
Contributor Author

Sorry about that let me remove them.

@abdnafees
Copy link
Contributor Author

Would it be useful to add .DS_Store to .gitignore?

@abdnafees
Copy link
Contributor Author

I hope it worked, I can't see the files now. Please confirm.

.gitignore Outdated
@@ -89,4 +89,4 @@ venv/
.spyderproject

# Rope project settings
.ropeproject
.ropeproject
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a newline at the end of the file.

Suggested change
.ropeproject
.ropeproject

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let me add it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check now.

.gitignore Outdated
.ropeproject
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't it show the new line I added?
Screenshot 2022-11-16 at 01 56 22

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why, but it also doesn't belong to this PR.

I will batch-commit my suggestions and merge this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thank you for the help.

@ezio-melotti ezio-melotti merged commit 71f3b76 into python:main Nov 15, 2022
@ezio-melotti
Copy link
Member

Done, thanks for the PR!

@abdnafees
Copy link
Contributor Author

Thank you for the assistance. Really appreciate it.

@ezio-melotti ezio-melotti linked an issue Nov 15, 2022 that may be closed by this pull request
@abdnafees abdnafees deleted the update-setup-guide-and-bootcamp branch March 13, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify documentation between setup guide and boot camp
3 participants