-
-
Notifications
You must be signed in to change notification settings - Fork 864
Update steps for 'Getting the source code' and link 'Git Bootcamp' #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update steps for 'Getting the source code' and link 'Git Bootcamp' #986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
There are two .DS_Store
files that got included accidentally and should be removed.
I usually use git add -p
while adding changes, in order to both verify exactly what gets added and to review it while I do (and sometimes also to break changes into multiple commits).
Sorry about that let me remove them. |
Would it be useful to add |
I hope it worked, I can't see the files now. Please confirm. |
.gitignore
Outdated
@@ -89,4 +89,4 @@ venv/ | |||
.spyderproject | |||
|
|||
# Rope project settings | |||
.ropeproject | |||
.ropeproject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a newline at the end of the file.
.ropeproject | |
.ropeproject | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let me add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check now.
.gitignore
Outdated
.ropeproject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why, but it also doesn't belong to this PR.
I will batch-commit my suggestions and merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thank you for the help.
Done, thanks for the PR! |
Thank you for the assistance. Really appreciate it. |
This PR contains the following changes mentioned in issue number #964: