-
-
Notifications
You must be signed in to change notification settings - Fork 864
Fix some markup (including 2 false-positives). #957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
similar to :samp:`"Please refer to the :ref:\`{security-considerations}\` | ||
section for important information on how to avoid common mistakes."`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* `Lib/test/test_exceptions.py`. | ||
* ``Lib/test/test_grammar.py``. | ||
* ``Lib/test/test_syntax.py``. | ||
* ``Lib/test/test_exceptions.py``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were actual errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just link the actual files (on GitHub instead)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be a good improvement for another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`issue tracker`_ and submit a :ref:`pull request <pullrequest>`. | ||
Once you have increased coverage, | ||
you need to create an issue on the `issue tracker`_ and | ||
submit a :ref:`pull request <pullrequest>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is another workaround: by reflowing the paragraph I avoid having the link and the ref
on the same line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe combine this with #956?
I'm planning to merge #956 just after this, but I wanted to make sure that these changes didn't trigger any errors with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor optional comment, otherwise LGTM
* `Lib/test/test_exceptions.py`. | ||
* ``Lib/test/test_grammar.py``. | ||
* ``Lib/test/test_syntax.py``. | ||
* ``Lib/test/test_exceptions.py``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just link the actual files (on GitHub instead)?
(Oops, wasn't showing as merged first) |
This PR fixes markup errors exposed by
sphinx-lint
0.6.3
, even though two of them are actually false positives:See also:
sphinx-lint
to 0.6.3 #956(cc @JulienPalard, @hugovk, @CAM-Gerlach)